Bug 32366 - BatchDeleteBiblio task should have tests to prove indexing all takes place in one step
Summary: BatchDeleteBiblio task should have tests to prove indexing all takes place in...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 30460
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-29 14:50 UTC by Martin Renvoize (ashimema)
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01
Circulation function:

Attachments
Bug 32366: (bug 30460 follow-up) Add tests (2.36 KB, patch)
2022-11-30 07:57 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 32366: (bug 30460 follow-up) Add tests (2.42 KB, patch)
2022-11-30 12:55 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-11-29 14:50:13 UTC 
We worked through changing our code such that we actioned the batch deletes in a loop passing skip_record_index and then finally passed a list of biblios to specialUpdate all in one hit at the end..

But we forgot to add unit tests for this change!
Comment 1 Jonathan Druart 2022-11-30 07:57:45 UTC 
Created attachment 144339 [details] [review]
Bug 32366: (bug 30460 follow-up) Add tests
Comment 2 Martin Renvoize (ashimema) 2022-11-30 12:55:50 UTC 
Created attachment 144346 [details] [review]
Bug 32366: (bug 30460 follow-up) Add tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2022-11-30 12:57:07 UTC 
Oh, thanks for jumping on this Jonathan, you beat me to it.

It's a nice trivial test once you wrap you head around it.. so going straight for a PQA.
Comment 4 Tomás Cohen Arazi (tcohen) 2022-12-01 13:04:50 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2022-12-05 12:21:33 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.