Bug 32376 - selenium/authentication_2fa.t produces artefact
Summary: selenium/authentication_2fa.t produces artefact
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on: 30588
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-30 07:32 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Circulation function:

Attachments
Bug 32376: Remove creation of selenium_failure_2.png (1.17 KB, patch)
2022-11-30 07:33 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 32376: Remove creation of selenium_failure_2.png (1.21 KB, patch)
2022-12-04 02:45 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32376: Remove creation of selenium_failure_2.png (1.27 KB, patch)
2023-01-20 14:25 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-30 07:32:12 UTC 
There is a selenium_failure_2.png screenshot that is created, even if the tests succeed.
Comment 1 Jonathan Druart 2022-11-30 07:33:46 UTC 
Created attachment 144338 [details] [review]
Bug 32376: Remove creation of selenium_failure_2.png

This was for debugging purpose.

Test plan:
Run the tests and confirm that the screenshot is not generated when the
patch is applied
Comment 2 David Nind 2022-12-04 02:45:27 UTC 
Created attachment 144417 [details] [review]
Bug 32376: Remove creation of selenium_failure_2.png

This was for debugging purpose.

Test plan:
Run the tests and confirm that the screenshot is not generated when the
patch is applied

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Kyle M Hall (khall) 2023-01-20 14:25:02 UTC 
Created attachment 145516 [details] [review]
Bug 32376: Remove creation of selenium_failure_2.png

This was for debugging purpose.

Test plan:
Run the tests and confirm that the screenshot is not generated when the
patch is applied

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-01-27 18:21:48 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-01-31 14:16:12 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass (lukeg) 2023-02-01 16:04:21 UTC 
Not needed in 22.05.x