When you 'finish receiving' you'll see information about your invoice on top. The fund pull down there is misaligned.
Created attachment 144387 [details] [review] Bug 32382: Fix alignment on invoice summary page To test: 1. Apply patch 2. Have some funds from budgets that are both active and inactive 3. Receive a basket and click 'Finish receiving' to get to the invoice page 4. Look at the Fund/Show inactive line and make sure it is aligned right 5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown 6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/ 7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears. 8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears. Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid.
Maybe this is for another bug but we build an HTML element called 'all_fund_dropdown'. This is never actually shown, we just use the inner HTML to build all the other '.fund_dropdown' dropdowns on the page. Would it not be better to handle that all with JS?
Alignment looks good. On both the Shipping fund and the Adjustment fund, after I've checked the Show Inactive box once, inactive funds show in the dropdown forever, even after I uncheck the box. I've confirmed this doesn't happen without your patches.
Created attachment 144727 [details] [review] Bug 32382: (follow-up) Fix selector
(In reply to Andrew Fuerste-Henry from comment #3) > Alignment looks good. > > On both the Shipping fund and the Adjustment fund, after I've checked the > Show Inactive box once, inactive funds show in the dropdown forever, even > after I uncheck the box. I've confirmed this doesn't happen without your > patches. Nice catch, I provided a follow up that should fix that.
Created attachment 144853 [details] [review] Bug 32382: Fix alignment on invoice summary page To test: 1. Apply patch 2. Have some funds from budgets that are both active and inactive 3. Receive a basket and click 'Finish receiving' to get to the invoice page 4. Look at the Fund/Show inactive line and make sure it is aligned right 5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown 6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/ 7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears. 8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears. Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 144854 [details] [review] Bug 32382: (follow-up) Fix selector Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
This is a great bug fix. For the future, I think we should reuse the new logic from the 'receive' form where we have the sub-headings for the budgets and the 'keep current' feature for a fund you don't have access to. I've filed that separately: Bug 32760 - Reuse new display of funds list from bug 20212 for shipping cost fund list
Created attachment 145835 [details] [review] Bug 32382: Fix alignment on invoice summary page To test: 1. Apply patch 2. Have some funds from budgets that are both active and inactive 3. Receive a basket and click 'Finish receiving' to get to the invoice page 4. Look at the Fund/Show inactive line and make sure it is aligned right 5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown 6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/ 7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears. 8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears. Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 145836 [details] [review] Bug 32382: (follow-up) Fix selector Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Missing dependencies for 22.05.x, no backport.