Bug 32382 - Fund input misaligned on invoice summary page
Summary: Fund input misaligned on invoice summary page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-30 21:01 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32382: Fix alignment on invoice summary page (7.32 KB, patch)
2022-12-02 00:26 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32382: (follow-up) Fix selector (972 bytes, patch)
2022-12-19 23:50 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32382: Fix alignment on invoice summary page (7.38 KB, patch)
2022-12-27 19:30 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32382: (follow-up) Fix selector (1.01 KB, patch)
2022-12-27 19:30 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32382: Fix alignment on invoice summary page (7.43 KB, patch)
2023-01-30 23:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32382: (follow-up) Fix selector (1.06 KB, patch)
2023-01-30 23:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-30 21:01:54 UTC
When you 'finish receiving' you'll see information about your invoice on top. The fund pull down there is misaligned.
Comment 1 Lucas Gass 2022-12-02 00:26:12 UTC
Created attachment 144387 [details] [review]
Bug 32382: Fix alignment on invoice summary page

To test:

1. Apply patch
2. Have some funds from budgets that are both active and inactive
3. Receive a basket and click 'Finish receiving' to get to the invoice page
4. Look at the Fund/Show inactive line and make sure it is aligned right
5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown
6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/
7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears.
8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears.

Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid.
Comment 2 Lucas Gass 2022-12-02 00:29:03 UTC
Maybe this is for another bug but we build an HTML element called 'all_fund_dropdown'. This is never actually shown, we just use the inner HTML to build all the other '.fund_dropdown' dropdowns on the page. 

Would it not be better to handle that all with JS?
Comment 3 Andrew Fuerste-Henry 2022-12-09 19:28:17 UTC
Alignment looks good.

On both the Shipping fund and the Adjustment fund, after I've checked the Show Inactive box once, inactive funds show in the dropdown forever, even after I uncheck the box. I've confirmed this doesn't happen without your patches.
Comment 4 Lucas Gass 2022-12-19 23:50:54 UTC
Created attachment 144727 [details] [review]
Bug 32382: (follow-up) Fix selector
Comment 5 Lucas Gass 2022-12-19 23:51:31 UTC
(In reply to Andrew Fuerste-Henry from comment #3)
> Alignment looks good.
> 
> On both the Shipping fund and the Adjustment fund, after I've checked the
> Show Inactive box once, inactive funds show in the dropdown forever, even
> after I uncheck the box. I've confirmed this doesn't happen without your
> patches.

Nice catch, I provided a follow up that should fix that.
Comment 6 ByWater Sandboxes 2022-12-27 19:30:01 UTC
Created attachment 144853 [details] [review]
Bug 32382: Fix alignment on invoice summary page

To test:

1. Apply patch
2. Have some funds from budgets that are both active and inactive
3. Receive a basket and click 'Finish receiving' to get to the invoice page
4. Look at the Fund/Show inactive line and make sure it is aligned right
5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown
6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/
7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears.
8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears.

Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 7 ByWater Sandboxes 2022-12-27 19:30:06 UTC
Created attachment 144854 [details] [review]
Bug 32382: (follow-up) Fix selector

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 8 Katrin Fischer 2023-01-30 23:39:08 UTC
This is a great bug fix. 

For the future, I think we should reuse the new logic from the 'receive' form where we have the sub-headings for the budgets and the 'keep current' feature for a fund you don't have access to. 

I've filed that separately:
Bug 32760 - Reuse new display of funds list from bug 20212 for shipping cost fund list
Comment 9 Katrin Fischer 2023-01-30 23:39:52 UTC
Created attachment 145835 [details] [review]
Bug 32382: Fix alignment on invoice summary page

To test:

1. Apply patch
2. Have some funds from budgets that are both active and inactive
3. Receive a basket and click 'Finish receiving' to get to the invoice page
4. Look at the Fund/Show inactive line and make sure it is aligned right
5. With some inactive funds click 'Show inactive' and make sure they appear in this dropdown
6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks correct there as well/
7. Make an adjustment and click 'Update adjustments' make sure the line also looks right in the table that appears.
8. Inside that table make sure you can click the 'Show inactive' checkbox and the inactive budgets appears.

Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML body so it will be valid.

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2023-01-30 23:39:57 UTC
Created attachment 145836 [details] [review]
Bug 32382: (follow-up) Fix selector

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Tomás Cohen Arazi 2023-01-31 12:41:51 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 12 Jacob O'Mara 2023-01-31 17:46:40 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 13 Lucas Gass 2023-02-03 21:45:24 UTC
Missing dependencies for 22.05.x, no backport.