Bug 32389 - Syndetics links are built wrong on the staff results page
Summary: Syndetics links are built wrong on the staff results page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 21225
Blocks:
  Show dependency treegraph
 
Reported: 2022-12-01 17:33 UTC by Lucas Gass
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01,22.05.09


Attachments
Bug 32389: Fix Syndetics link on staff results page (1.88 KB, patch)
2022-12-01 17:43 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32389: Fix Syndetics link on staff results page (1.93 KB, patch)
2022-12-02 12:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32389: Fix Syndetics link on staff results page (1.99 KB, patch)
2022-12-07 21:26 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-12-01 17:33:35 UTC
TO recreate:

1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Notice the page you are being directed to is something like:


http://localhost:8081/cgi-bin/koha/catalogue/?biblionumber=117
Comment 1 Lucas Gass 2022-12-01 17:39:41 UTC
We are attempting to pass in this template variable: [% DetailPage | url %]

I can't find this anywhere else in the codebase, so maybe we should just hardcode this bit?
Comment 2 Lucas Gass 2022-12-01 17:43:08 UTC
Created attachment 144383 [details] [review]
Bug 32389: Fix Syndetics link on staff results page

To test:
1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Apply patch
5. Link works!
Comment 3 Owen Leonard 2022-12-02 12:39:21 UTC
Created attachment 144397 [details] [review]
Bug 32389: Fix Syndetics link on staff results page

To test:
1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Apply patch
5. Link works!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2022-12-02 12:40:54 UTC
Signed off based on the content of the patch even though I don't have Syndetics credentials to test live.

I suspect the origin of this bug was some variation on handling the BiblioDefaultView system preference.
Comment 5 Katrin Fischer 2022-12-07 21:26:25 UTC
Created attachment 144492 [details] [review]
Bug 32389: Fix Syndetics link on staff results page

To test:
1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Apply patch
5. Link works!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-12-12 15:21:23 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2022-12-15 13:27:15 UTC
Nice work everyone!

Pushed to 22.11.x for the next release
Comment 8 Sarah Cornell 2023-01-19 16:01:05 UTC
Is there any chance to get this on 22.05? We were looking forward to syndetics images on the staff side.
Comment 9 Lucas Gass 2023-01-19 16:06:49 UTC
Backported to 22.05.x for upcoming 22.05.09 release
Comment 10 Arthur Suzuki 2023-01-26 10:10:05 UTC
this one seems to depends on 21225 which was not released for 21.11.x.
Won't backport