Whenever you try to build the OPAC view, this happens: root@kohadevbox:koha(master)$ kshell kohadev-koha@kohadevbox:/kohadevbox/koha$ yarn build --view opac yarn run v1.22.19 $ gulp build --view opac [18:27:38] Using gulpfile /kohadevbox/koha/gulpfile.js [18:27:38] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/functions. on line 37 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> @import "../../../../../node_modules/bootstrap/scss/functions"; ^ [18:27:38] Finished 'build' after 36 ms Done in 1.39s.
Created attachment 144487 [details] [review] Bug 32422: Hardcoded paths in _common.scss precent using external node_modules This patch makes: - gulpfile.js add the parent dir's node_modules to the sass include path - removes hardcoded paths from _common.scss To test: 1. Have the latest KTD image (this is not KTD specific, but easier to test) 2. Make sure you don't have any node_modules/ dir in your koha clone 3. Run: $ kshell k$ yarn build --view opac => FAIL: You get: kohadev-koha@kohadevbox:/kohadevbox/koha$ yarn build --view opac yarn run v1.22.19 $ gulp build --view opac [18:27:38] Using gulpfile /kohadevbox/koha/gulpfile.js [18:27:38] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/functions. on line 37 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> @import "../../../../../node_modules/bootstrap/scss/functions"; ^ 4. Apply this patch 5. Repeat 3 => SUCCESS: It builds! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 144488 [details] [review] Bug 32422: Hardcoded paths in _common.scss precent using external node_modules This patch makes: - gulpfile.js add the parent dir's node_modules to the sass include path - removes hardcoded paths from _common.scss To test: 1. Have the latest KTD image (this is not KTD specific, but easier to test) 2. Make sure you don't have any node_modules/ dir in your koha clone 3. Run: $ kshell k$ yarn build --view opac => FAIL: You get: kohadev-koha@kohadevbox:/kohadevbox/koha$ yarn build --view opac yarn run v1.22.19 $ gulp build --view opac [18:27:38] Using gulpfile /kohadevbox/koha/gulpfile.js [18:27:38] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/functions. on line 37 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> @import "../../../../../node_modules/bootstrap/scss/functions"; ^ 4. Apply this patch 5. Repeat 3 => SUCCESS: It builds! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 144523 [details] [review] Bug 32422: Hardcoded paths in _common.scss precent using external node_modules This patch makes: - gulpfile.js add the parent dir's node_modules to the sass include path - removes hardcoded paths from _common.scss To test: 1. Have the latest KTD image (this is not KTD specific, but easier to test) 2. Make sure you don't have any node_modules/ dir in your koha clone 3. Run: $ kshell k$ yarn build --view opac => FAIL: You get: kohadev-koha@kohadevbox:/kohadevbox/koha$ yarn build --view opac yarn run v1.22.19 $ gulp build --view opac [18:27:38] Using gulpfile /kohadevbox/koha/gulpfile.js [18:27:38] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/functions. on line 37 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> @import "../../../../../node_modules/bootstrap/scss/functions"; ^ 4. Apply this patch 5. Repeat 3 => SUCCESS: It builds! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144531 [details] [review] Bug 32422: Hardcoded paths in _common.scss precent using external node_modules This patch makes: - gulpfile.js add the parent dir's node_modules to the sass include path - removes hardcoded paths from _common.scss To test: 1. Have the latest KTD image (this is not KTD specific, but easier to test) 2. Make sure you don't have any node_modules/ dir in your koha clone 3. Run: $ kshell k$ yarn build --view opac => FAIL: You get: kohadev-koha@kohadevbox:/kohadevbox/koha$ yarn build --view opac yarn run v1.22.19 $ gulp build --view opac [18:27:38] Using gulpfile /kohadevbox/koha/gulpfile.js [18:27:38] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/functions. on line 37 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> @import "../../../../../node_modules/bootstrap/scss/functions"; ^ 4. Apply this patch 5. Repeat 3 => SUCCESS: It builds! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This gets the sandboxes happy again at building css for the OPAC.. and it cleans up our css to boot. Nice work, no regressions found. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for the next release
This depends on Bug 32030?