Bug 32435 - Add resolution types to catalog concerns
Summary: Add resolution types to catalog concerns
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 35628
Blocks: 35657 36802
  Show dependency treegraph
 
Reported: 2022-12-09 15:15 UTC by Martin Renvoize
Modified: 2024-05-24 12:11 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds a new `TICKET_RESOLUTION` authorized value type. You may use it to optionally add new resolution values to the catalog concerns workflow. **Sponsored by** *PTFS Europe*
Version(s) released in:
24.05.00


Attachments
Bug 32435: Add status to ticket_updates table (2.17 KB, patch)
2023-12-21 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: DBIC Schema dump (1.35 KB, patch)
2023-12-21 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add status to ticket_update definition (878 bytes, patch)
2023-12-21 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (4.84 KB, patch)
2023-12-21 16:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (1.09 KB, patch)
2023-12-22 16:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (4.53 KB, patch)
2023-12-22 16:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (1.13 KB, patch)
2023-12-24 09:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (4.57 KB, patch)
2023-12-24 09:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (4.53 KB, patch)
2023-12-27 09:30 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.82 KB, patch)
2023-12-27 11:59 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.27 KB, patch)
2023-12-27 11:59 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.31 KB, patch)
2024-02-27 11:11 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.87 KB, patch)
2024-04-16 12:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.32 KB, patch)
2024-04-16 12:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.90 KB, patch)
2024-04-16 12:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.32 KB, patch)
2024-04-16 12:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.90 KB, patch)
2024-04-25 14:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.32 KB, patch)
2024-04-25 14:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.90 KB, patch)
2024-04-25 16:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.32 KB, patch)
2024-04-25 16:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Unit tests for Ticket/Ticket::Update change (4.76 KB, patch)
2024-04-25 16:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.99 KB, patch)
2024-04-26 07:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.41 KB, patch)
2024-04-26 07:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32435: Unit tests for Ticket/Ticket::Update change (4.85 KB, patch)
2024-04-26 07:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.96 KB, patch)
2024-04-26 12:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.38 KB, patch)
2024-04-26 12:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Unit tests for Ticket/Ticket::Update change (4.85 KB, patch)
2024-04-26 12:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add TICKET_RESOLUTION authorized value (2.96 KB, patch)
2024-04-29 17:44 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Add resolution states to Catalog concerns (7.24 KB, patch)
2024-04-29 17:44 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32435: Unit tests for Ticket/Ticket::Update change (4.85 KB, patch)
2024-04-29 17:44 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-12-09 15:15:59 UTC
It would be nice to have a descriptive resolution text for different standard resolutions to catalog problems reported via the new catalog concerns feature.

We're envisaging using the authorized values system to populate a drop down of resolutions available.
Comment 1 Martin Renvoize 2023-12-21 16:53:17 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2023-12-21 16:53:19 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2023-12-21 16:53:22 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2023-12-21 16:53:24 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize 2023-12-22 16:25:24 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize 2023-12-22 16:25:26 UTC
Created attachment 160261 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.
Comment 7 David Nind 2023-12-24 09:13:55 UTC Comment hidden (obsolete)
Comment 8 David Nind 2023-12-24 09:13:58 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2023-12-27 09:30:30 UTC Comment hidden (obsolete)
Comment 10 Martin Renvoize 2023-12-27 11:59:51 UTC
Created attachment 160321 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Comment 11 Martin Renvoize 2023-12-27 11:59:53 UTC
Created attachment 160322 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Comment 12 PTFS Europe Sandboxes 2024-02-27 11:11:59 UTC
Created attachment 162493 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 13 Martin Renvoize 2024-04-16 12:29:10 UTC
Created attachment 164919 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 14 Martin Renvoize 2024-04-16 12:29:13 UTC
Created attachment 164920 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 15 Martin Renvoize 2024-04-16 12:29:32 UTC
Quick rebase to make sure it all still applies.
Comment 16 Martin Renvoize 2024-04-16 12:32:52 UTC
Created attachment 164921 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 17 Martin Renvoize 2024-04-16 12:32:54 UTC
Created attachment 164922 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 18 Martin Renvoize 2024-04-16 12:33:28 UTC
Tidied the db update to pass QA scripts.
Comment 19 Ray Delahunty 2024-04-16 12:35:48 UTC
Should I repeat the signoff? Is this necessary after such a db update?
Comment 20 Martin Renvoize 2024-04-25 14:27:53 UTC
Created attachment 165558 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 21 Martin Renvoize 2024-04-25 14:27:56 UTC
Created attachment 165559 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 22 Martin Renvoize 2024-04-25 16:03:28 UTC
Created attachment 165565 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 23 Martin Renvoize 2024-04-25 16:03:31 UTC
Created attachment 165566 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 24 Martin Renvoize 2024-04-25 16:03:33 UTC
Created attachment 165567 [details] [review]
Bug 32435: Unit tests for Ticket/Ticket::Update change

We add a fallback to allow TICKET_RESOLUTIONS to be returned in the
strings_map as additional TICKET_STATUS states.
Comment 25 Marcel de Rooy 2024-04-26 07:19:01 UTC
Created attachment 165611 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 26 Marcel de Rooy 2024-04-26 07:19:03 UTC
Created attachment 165612 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 27 Marcel de Rooy 2024-04-26 07:19:05 UTC
Created attachment 165613 [details] [review]
Bug 32435: Unit tests for Ticket/Ticket::Update change

We add a fallback to allow TICKET_RESOLUTIONS to be returned in the
strings_map as additional TICKET_STATUS states.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 28 Marcel de Rooy 2024-04-26 07:19:48 UTC
Passing QA but with the following remarks:

 WARN   t/db_dependent/Koha/Ticket.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 44, now: 48)

 WARN   t/db_dependent/Koha/Ticket/Update.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 10, now: 14)

Added Resolved_2 status. Resolved a concern. Resolved_2 does not show up under main status. But is listed (suboptimal) when clicking details.

        my $av = Koha::AuthorisedValues->search(
            {
                category         => 'TICKET_STATUS',
                authorised_value => $self->status,
            }
        );
        # Fall back to TICKET_RESOLUTION as needed
        if ( !$av->count ) {
            $av = Koha::AuthorisedValues->search(
                {
                    category         => 'TICKET_RESOLUTION',
                    authorised_value => $self->status,
                }
            );
        }
No blocker. But not sure if we create maintainable code when we are going to look for statuses in several AVs.
Comment 29 Martin Renvoize 2024-04-26 12:57:55 UTC
Created attachment 165656 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 30 Martin Renvoize 2024-04-26 12:57:57 UTC
Created attachment 165657 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 31 Martin Renvoize 2024-04-26 12:58:00 UTC
Created attachment 165658 [details] [review]
Bug 32435: Unit tests for Ticket/Ticket::Update change

We add a fallback to allow TICKET_RESOLUTIONS to be returned in the
strings_map as additional TICKET_STATUS states.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 32 Martin Renvoize 2024-04-26 12:59:48 UTC
Just fixed the Tidy issue.

I agree with the somewhat odd use of two AV's.. I couldn't come up with a better solution that gave the end result people wanted.. maybe we'll eventually migrate these out of AV's though if they end up with a stronger workflow management piece.. which is planned.. at that point I could see a 'flag' being added that marked some as 'resolutions' vs 'general status' steps.

I'll certainly bear that in mind for the future.

Thanks for the review.
Comment 33 Katrin Fischer 2024-04-29 16:40:20 UTC
Waiting for rebase of dependency. Please switch back to Passed QA once resolved.
Comment 34 Martin Renvoize 2024-04-29 17:44:51 UTC
Created attachment 165781 [details] [review]
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 35 Martin Renvoize 2024-04-29 17:44:54 UTC
Created attachment 165782 [details] [review]
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 36 Martin Renvoize 2024-04-29 17:44:57 UTC
Created attachment 165783 [details] [review]
Bug 32435: Unit tests for Ticket/Ticket::Update change

We add a fallback to allow TICKET_RESOLUTIONS to be returned in the
strings_map as additional TICKET_STATUS states.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 37 Katrin Fischer 2024-04-30 10:01:44 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 38 Fridolin Somers 2024-05-24 12:11:52 UTC
Not backported to 23.11.x