Bug 32437 - When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite
Summary: When adding to a basket form a staged file and matching the imported records ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 32054
Blocks:
  Show dependency treegraph
 
Reported: 2022-12-09 15:45 UTC by Nick Clemens
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32437: Cleanup script (5.05 KB, patch)
2022-12-12 18:47 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Add Objects for ImportAuths (10.25 KB, patch)
2022-12-12 18:47 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Add replace method to Koha::Import::Record objects (6.23 KB, patch)
2022-12-12 18:47 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Honor overlay setting in staged batch when adding to a basket (2.85 KB, patch)
2022-12-12 18:47 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Cleanup script (5.05 KB, patch)
2022-12-14 12:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Add Objects for ImportAuths (11.41 KB, patch)
2022-12-14 12:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Add replace method to Koha::Import::Record objects (6.23 KB, patch)
2022-12-14 12:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Honor overlay setting in staged batch when adding to a basket (2.85 KB, patch)
2022-12-14 12:26 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Cleanup script (5.11 KB, patch)
2023-01-11 21:54 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32437: Add Objects for ImportAuths (11.47 KB, patch)
2023-01-11 21:54 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32437: Add replace method to Koha::Import::Record objects (6.29 KB, patch)
2023-01-11 21:55 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32437: Honor overlay setting in staged batch when adding to a basket (2.91 KB, patch)
2023-01-11 21:55 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32437: Cleanup script (5.21 KB, patch)
2023-03-03 07:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Add Objects for ImportAuths (11.57 KB, patch)
2023-03-03 07:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Add replace method to Koha::Import::Record objects (6.38 KB, patch)
2023-03-03 07:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Honor overlay setting in staged batch when adding to a basket (3.01 KB, patch)
2023-03-03 07:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: (QA follow-up) Change to replace POD (1.03 KB, patch)
2023-03-03 07:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Cleanup script (5.17 KB, patch)
2023-03-16 15:16 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Add Objects for ImportAuths (9.33 KB, patch)
2023-03-16 15:16 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Add replace method to Koha::Import::Record objects (6.34 KB, patch)
2023-03-16 15:16 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Honor overlay setting in staged batch when adding to a basket (2.97 KB, patch)
2023-03-16 15:17 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: (QA follow-up) Change to replace POD (1011 bytes, patch)
2023-03-16 15:17 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present (1.22 KB, patch)
2023-03-16 15:17 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: DO NOT PUSH - Schema Updates (2.32 KB, patch)
2023-03-16 15:17 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present (1.22 KB, patch)
2023-03-16 16:07 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32437: Cleanup script (5.21 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Add Objects for ImportAuths (9.37 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Add replace method to Koha::Import::Record objects (6.38 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: Honor overlay setting in staged batch when adding to a basket (3.01 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: (QA follow-up) Change to replace POD (1.03 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: DO NOT PUSH - Schema Updates (2.42 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present (1.31 KB, patch)
2023-03-17 08:28 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-12-09 15:45:40 UTC
To recreate:
1 - Stage the sample file on this report using the options below
    (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
2 - Make sure to match using KohaBiblio (999c)
3 - Set option "Replace existing record" if match found
4 - Once record is staged go to Acquisitions
5 - Find a vendor and select/create an open basket
6 - Add to basket from the staged file
7 - Add order info and save
8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
9 - Check the staged records batch - note the diff shows that new record should have overwritten
Comment 1 Nick Clemens 2022-12-12 18:47:37 UTC
Created attachment 144538 [details] [review]
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable
Comment 2 Nick Clemens 2022-12-12 18:47:40 UTC
Created attachment 144539 [details] [review]
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects
Comment 3 Nick Clemens 2022-12-12 18:47:44 UTC
Created attachment 144540 [details] [review]
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t
Comment 4 Nick Clemens 2022-12-12 18:47:47 UTC
Created attachment 144541 [details] [review]
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
     (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
 9 - Check the staged records batch - note the diff shows that new record should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to  'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'
Comment 5 Nick Clemens 2022-12-14 12:26:01 UTC
Created attachment 144573 [details] [review]
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable
Comment 6 Nick Clemens 2022-12-14 12:26:05 UTC
Created attachment 144574 [details] [review]
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects
Comment 7 Nick Clemens 2022-12-14 12:26:08 UTC
Created attachment 144575 [details] [review]
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t
Comment 8 Nick Clemens 2022-12-14 12:26:12 UTC
Created attachment 144576 [details] [review]
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
     (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
 9 - Check the staged records batch - note the diff shows that new record should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to  'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'
Comment 9 ByWater Sandboxes 2023-01-11 21:54:55 UTC
Created attachment 145223 [details] [review]
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 10 ByWater Sandboxes 2023-01-11 21:54:59 UTC
Created attachment 145224 [details] [review]
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 11 ByWater Sandboxes 2023-01-11 21:55:03 UTC
Created attachment 145225 [details] [review]
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 12 ByWater Sandboxes 2023-01-11 21:55:07 UTC
Created attachment 145226 [details] [review]
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
     (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
 9 - Check the staged records batch - note the diff shows that new record should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to  'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 13 Marcel de Rooy 2023-02-24 11:02:08 UTC
Cannot finish right now, happy to continue next week..
Comment 14 Marcel de Rooy 2023-03-03 07:28:43 UTC
Created attachment 147677 [details] [review]
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 15 Marcel de Rooy 2023-03-03 07:28:46 UTC
Created attachment 147678 [details] [review]
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 16 Marcel de Rooy 2023-03-03 07:28:48 UTC
Created attachment 147679 [details] [review]
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 17 Marcel de Rooy 2023-03-03 07:28:50 UTC
Created attachment 147680 [details] [review]
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
     (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
 9 - Check the staged records batch - note the diff shows that new record should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to  'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 18 Marcel de Rooy 2023-03-03 07:28:53 UTC
Created attachment 147681 [details] [review]
Bug 32437: (QA follow-up) Change to replace POD

Making it more visible that this also applies to authority
records.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 19 Marcel de Rooy 2023-03-03 07:30:33 UTC
Hmm. Still looking a bit at the dbrev
Comment 20 Marcel de Rooy 2023-03-03 07:36:19 UTC
 Koha/Schema/Result/ImportAuth.pm              | 23 ++++++--
 Koha/Schema/Result/ImportRecord.pm            | 12 ++---

These files should be removed from the patch and be on a separate DO NOT PUSH-one.
Comment 21 Marcel de Rooy 2023-03-03 07:37:35 UTC
        } elsif( !primary_key_exists('import_auths','import_record_id') ){
            say $out "Found an existing PRIMARY KEY on import_auths table";
            say $out "You must delete this key and replace it with a key on import_record_id";
        } else {
            say $out "PRIMARY KEY import_record_id on import_auths already exists";

Since we assume in the schema that the primary key is import_record_id, we should bail out in the middle clause where we find another PK.
Comment 22 Marcel de Rooy 2023-03-03 07:37:59 UTC
Temporary switch to FQA.
Comment 23 Nick Clemens 2023-03-16 15:16:53 UTC
Created attachment 148270 [details] [review]
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 24 Nick Clemens 2023-03-16 15:16:55 UTC
Created attachment 148271 [details] [review]
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 25 Nick Clemens 2023-03-16 15:16:57 UTC
Created attachment 148272 [details] [review]
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 26 Nick Clemens 2023-03-16 15:17:00 UTC
Created attachment 148273 [details] [review]
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
     (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
 9 - Check the staged records batch - note the diff shows that new record should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to  'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 27 Nick Clemens 2023-03-16 15:17:02 UTC
Created attachment 148274 [details] [review]
Bug 32437: (QA follow-up) Change to replace POD

Making it more visible that this also applies to authority
records.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 28 Nick Clemens 2023-03-16 15:17:04 UTC
Created attachment 148275 [details] [review]
Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present
Comment 29 Nick Clemens 2023-03-16 15:17:06 UTC
Created attachment 148276 [details] [review]
Bug 32437: DO NOT PUSH - Schema Updates
Comment 30 Nick Clemens 2023-03-16 16:07:41 UTC
Created attachment 148277 [details] [review]
Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present
Comment 31 Marcel de Rooy 2023-03-17 07:56:43 UTC
Looking here again
Comment 32 Marcel de Rooy 2023-03-17 08:28:43 UTC
Created attachment 148300 [details] [review]
Bug 32437: Cleanup script

This patch:
- fixes some indentation
- flips unless-else to if-else for readability
- expands some comments for clarity
- removes unused biblioitemnum variable

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 33 Marcel de Rooy 2023-03-17 08:28:46 UTC
Created attachment 148301 [details] [review]
Bug 32437: Add Objects for ImportAuths

This patch:
1 - Adds an atomic update to add a primary key to import_auths table
2 - Adds objects for Koha::Import::Records::Auths
3 - Adds tests for import auth and biblio objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 34 Marcel de Rooy 2023-03-17 08:28:48 UTC
Created attachment 148302 [details] [review]
Bug 32437: Add replace method to Koha::Import::Record objects

This patch adds a replace routine to Koha::Import::Record - largely
copying and updating code from C4::ImportBatch

To test:
prove t/db_dependent/Koha/Import/Records.t

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 35 Marcel de Rooy 2023-03-17 08:28:50 UTC
Created attachment 148303 [details] [review]
Bug 32437: Honor overlay setting in staged batch when adding to a basket

This patch uses the replace method added in last patch to ensure
records are overlayed when added to a basket

To test:
 1 - Stage the sample file on this report using the options below
     (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version)
 2 - Make sure to match using KohaBiblio (999c)
 3 - Set option "Replace existing record" if match found
 4 - Once record is staged go to Acquisitions
 5 - Find a vendor and select/create an open basket
 6 - Add to basket from the staged file
 7 - Add order info and save
 8 - Check the record, title is unchanged -  Sample file should add 'New and improved!'
 9 - Check the staged records batch - note the diff shows that new record should have overwritten
10 - Apply patch
11 - Stage file, match on KohaBiblio, set action if matching record found to 'Ignore incoming record'
12 - Add to basket from the staged file and save
13 - Confirm record not overlayed when not reuqested
14 - Stage file, match on KohaBiblio, set action if mathc record found to  'Replace existing...'
15 - Add to basket from staged file and save
16 - Confirm the record is updated to 'New and improved!'

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 36 Marcel de Rooy 2023-03-17 08:28:53 UTC
Created attachment 148304 [details] [review]
Bug 32437: (QA follow-up) Change to replace POD

Making it more visible that this also applies to authority
records.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 37 Marcel de Rooy 2023-03-17 08:28:55 UTC
Created attachment 148305 [details] [review]
Bug 32437: DO NOT PUSH - Schema Updates

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 38 Marcel de Rooy 2023-03-17 08:28:58 UTC
Created attachment 148306 [details] [review]
Bug 32437: (QA follow-up) Prevent upgrade if wrong PRIMARY KEY key present

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 39 Tomás Cohen Arazi 2023-03-31 11:06:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 40 Jacob O'Mara 2023-04-16 17:24:19 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 41 Lucas Gass 2023-04-24 17:30:12 UTC
Missing dependencies for 22.05.x, no backport