The 'categories' table in Administration-Table settings doesn't have a 'password expiration' option, and it appears to be causing column selection for the table to be shifted by one starting with 'age required'. When I select to hide 'age required', 'Password expired' is the column that's actually hidden. All columns after that appear to follow by being off by one.
Correction: it's the 'categories' page, but the table ID is 'patron_categories'
Created attachment 144881 [details] [review] Bug 32460: Add missing columns to table configuration for patron categories The table settings were missing the recently added columns, resulting in strange behaviour using the column visibility settings: * patron expiration * can be guarantee * exclude from local holds priority To test: * Go to administration > patron categories * Verify some columns are missing from the Columns selection * Apply patch * Verify the missing columns are now present and all columns can be hidden/unhidden as expected * Change settings for the table in administration > table settings * Verify the settings have the desired effect
The columns below are all now visible and working appropriately in the Patron Categories table: *password expiration - (I think this is what you meant instead of patron expiration) *can be guarantee *exclude from local holds priority Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 145866 [details] [review] Bug 32460: Add missing columns to table configuration for patron categories The table settings were missing the recently added columns, resulting in strange behaviour using the column visibility settings: * patron expiration * can be guarantee * exclude from local holds priority To test: * Go to administration > patron categories * Verify some columns are missing from the Columns selection * Apply patch * Verify the missing columns are now present and all columns can be hidden/unhidden as expected * Change settings for the table in administration > table settings * Verify the settings have the desired effect Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
No regressions, Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.11
I don't reproduce this bug in 21.11, the mentioned columns seems not to be present in the database. won't apply unless needed.