In cancel_expired_holds we can add a reason to the cron send emails relating to cancellation, we should have the same here
Created attachment 144806 [details] [review] Bug 32518: Add reason option to cancel_unfilled_holds cronjob This adds a reaosn parameter and passes it into the cancellation if supplied To test: 1 - Place a hold for a patron in your system 2 - Run script with --days 0 -v 3 - verify that it would cancel the reserves (and that you are okay with cancelling the ones it found) 4 - Make sure you have a notice in the holds module with code 'HOLD_CANCELLATION' 5 - Set content of the notice like: [% IF hold.cancellation_reason=='too_old' %] Canceled old [% END %] 6 - Run script with --days 0 -v --reason too_bad -c 7 - Confirm hold cancelled, no notice sent to patron 8 - Place another hold 9 - Run script with --days 0 -v --reason too_old -c 10 - Confirm hold cancelled, notice sent to patron
Created attachment 144820 [details] [review] Bug 32518: Add reason option to cancel_unfilled_holds cronjob This adds a reaosn parameter and passes it into the cancellation if supplied To test: 1 - Place a hold for a patron in your system 2 - Run script with --days 0 -v 3 - verify that it would cancel the reserves (and that you are okay with cancelling the ones it found) 4 - Make sure you have a notice in the holds module with code 'HOLD_CANCELLATION' 5 - Set content of the notice like: [% IF hold.cancellation_reason=='too_old' %] Canceled old [% END %] 6 - Run script with --days 0 -v --reason too_bad -c 7 - Confirm hold cancelled, no notice sent to patron 8 - Place another hold 9 - Run script with --days 0 -v --reason too_old -c 10 - Confirm hold cancelled, notice sent to patron
Created attachment 145755 [details] [review] Bug 32518: Add reason option to cancel_unfilled_holds cronjob This adds a reaosn parameter and passes it into the cancellation if supplied To test: 1 - Place a hold for a patron in your system 2 - Run script with --days 0 -v 3 - verify that it would cancel the reserves (and that you are okay with cancelling the ones it found) 4 - Make sure you have a notice in the holds module with code 'HOLD_CANCELLATION' 5 - Set content of the notice like: [% IF hold.cancellation_reason=='too_old' %] Canceled old [% END %] 6 - Run script with --days 0 -v --reason too_bad -c 7 - Confirm hold cancelled, no notice sent to patron 8 - Place another hold 9 - Run script with --days 0 -v --reason too_old -c 10 - Confirm hold cancelled, notice sent to patron Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 147424 [details] [review] Bug 32518: Add reason option to cancel_unfilled_holds cronjob This adds a reaosn parameter and passes it into the cancellation if supplied To test: 1 - Place a hold for a patron in your system 2 - Run script with --days 0 -v 3 - verify that it would cancel the reserves (and that you are okay with cancelling the ones it found) 4 - Make sure you have a notice in the holds module with code 'HOLD_CANCELLATION' 5 - Set content of the notice like: [% IF hold.cancellation_reason=='too_old' %] Canceled old [% END %] 6 - Run script with --days 0 -v --reason too_bad -c 7 - Confirm hold cancelled, no notice sent to patron 8 - Place another hold 9 - Run script with --days 0 -v --reason too_old -c 10 - Confirm hold cancelled, notice sent to patron Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 147425 [details] [review] Bug 32518: (QA follow-up) Fix alignment Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, QA script happy, code looks good, passing QA :)
Pushed to master for 23.05. Nice work everyone, thanks!