Bug 32525 - Standardize labels between ILL request list and detail page
Summary: Standardize labels between ILL request list and detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact:
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-12-23 15:44 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19


Attachments
Bug 32525: Standardize labels on list of ILL requests and ILL request details page (4.38 KB, patch)
2023-02-10 23:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32525: Standardize labels on list of ILL requests and ILL request details page (4.43 KB, patch)
2023-02-13 13:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32525: Standardize labels on list of ILL requests and ILL request details page (4.51 KB, patch)
2023-02-23 14:43 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-12-23 15:44:43 UTC
It would help with documentation and translation if the labels for different information in ILL requests would be labeled the same in the list of requests and on the detail page:

* results: Staff notes, detail page: Notes. Staff notes is better.
* results: Type, detail page: Request type. Request type is better.
* results: Bibliographic record, detail: Bibliographic record ID. The latter is more accurate.
* results: Branch, detail: Library. Library is correct!
* results: Request ID, detail: Request number. The first is better.
Comment 1 Katrin Fischer 2023-02-10 23:03:50 UTC
Created attachment 146526 [details] [review]
Bug 32525: Standardize labels on list of ILL requests and ILL request details page

This changes some labels so they match up between the
ILL requests list and the detail page of a request:

* 'View biblio details' to 'View bibliographic record'
* 'View borrower details' to 'View patron details'
* 'Branch' table heading to 'Library' in list view
* 'Request number' to 'Request ID' in list view
* 'Type' to 'Request type' in detail view
* 'Bibliographic record' to 'Bibliographic record ID"

To test:
*  Install a backend and activate the ILL module, see:
   https://wiki.koha-community.org/wiki/ILL_backends
*  Add a new request
*  Compare the table headings with the labels on the detail page
*  Apply patch
*  Verify listed changes from above
Comment 2 Owen Leonard 2023-02-13 13:50:43 UTC
Created attachment 146582 [details] [review]
Bug 32525: Standardize labels on list of ILL requests and ILL request details page

This changes some labels so they match up between the
ILL requests list and the detail page of a request:

* 'View biblio details' to 'View bibliographic record'
* 'View borrower details' to 'View patron details'
* 'Branch' table heading to 'Library' in list view
* 'Request number' to 'Request ID' in list view
* 'Type' to 'Request type' in detail view
* 'Bibliographic record' to 'Bibliographic record ID"

To test:
*  Install a backend and activate the ILL module, see:
   https://wiki.koha-community.org/wiki/ILL_backends
*  Add a new request
*  Compare the table headings with the labels on the detail page
*  Apply patch
*  Verify listed changes from above

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2023-02-23 14:43:03 UTC
Created attachment 147239 [details] [review]
Bug 32525: Standardize labels on list of ILL requests and ILL request details page

This changes some labels so they match up between the
ILL requests list and the detail page of a request:

* 'View biblio details' to 'View bibliographic record'
* 'View borrower details' to 'View patron details'
* 'Branch' table heading to 'Library' in list view
* 'Request number' to 'Request ID' in list view
* 'Type' to 'Request type' in detail view
* 'Bibliographic record' to 'Bibliographic record ID"

To test:
*  Install a backend and activate the ILL module, see:
   https://wiki.koha-community.org/wiki/ILL_backends
*  Add a new request
*  Compare the table headings with the labels on the detail page
*  Apply patch
*  Verify listed changes from above

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2023-02-24 20:06:23 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-28 16:46:00 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-03-08 13:37:12 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 7 Arthur Suzuki 2023-03-29 12:33:48 UTC
applied to 21.11 for 21.11.19
Comment 8 wainuiwitikapark 2023-04-27 05:28:13 UTC
Not backported to 21.05.x