In Suggestions management, there is a sidebar menu to organize and filter suggestions. In the "Suggestion information" filter section, there is a checkbox "Include archived". When this box us unchecked, the archived suggestions are not displayed. When this box is checked, all suggestions are displayed, archived, and not archived. This is not the case anymore, only archived suggestions are displayed, supposedly since patch for bug 23991.
Created attachment 144833 [details] [review] Bug 32531: In suggestions, restore Include archived In Suggestions management, there is a sidebar menu to organize and filter suggestions. In the "Suggestion information" filter section, there is a checkbox "Include archived". When this box us unchecked, the archived suggestions are not displayed. When this box is checked, all suggestions are displayed, archived, and not archived. This is not the case anymore, only archived suggestions are displayed, supposedly since patch for bug 23991. TO TEST: 1. On a Koha installation remove all suggestions (in the table). 2. Create two suggestions. Archive one of them. 3. Check/Uncheck filter 'Include Archived'. Confirm that when the box is checked, you don't see anymore the unarchived suggestion. 4. Apply the patch. 5. Repeat 3, and confirm that the filter operates properly.
Created attachment 144872 [details] [review] Bug 32531: Restore behaviour of 'include archived' filter In Suggestions management, there is a sidebar menu to organize and filter suggestions. In the "Suggestion information" filter section, there is a checkbox "Include archived". When this box us unchecked, the archived suggestions are not displayed. When this box is checked, all suggestions are displayed, archived, and not archived. This is not the case anymore, only archived suggestions are displayed, supposedly since patch for bug 23991. TO TEST: 1. On a Koha installation remove all suggestions (in the table). 2. Create two suggestions. Archive one of them. 3. Check/Uncheck filter 'Include Archived'. Confirm that when the box is checked, you don't see anymore the unarchived suggestion. 4. Apply the patch. 5. Repeat 3, and confirm that the filter operates properly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144923 [details] [review] Bug 32531: Restore behaviour of 'include archived' filter In Suggestions management, there is a sidebar menu to organize and filter suggestions. In the "Suggestion information" filter section, there is a checkbox "Include archived". When this box us unchecked, the archived suggestions are not displayed. When this box is checked, all suggestions are displayed, archived, and not archived. This is not the case anymore, only archived suggestions are displayed, supposedly since patch for bug 23991. TO TEST: 1. On a Koha installation remove all suggestions (in the table). 2. Create two suggestions. Archive one of them. 3. Check/Uncheck filter 'Include Archived'. Confirm that when the box is checked, you don't see anymore the unarchived suggestion. 4. Apply the patch. 5. Repeat 3, and confirm that the filter operates properly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Oops, silly mistake!
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Missing dependencies for 22.05.x, no backport.