Bug 32544 - borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted system preferences
Summary: borrowers.flags should not be an option in any BorrowerMandatory or BorrowerU...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 32535
Blocks:
  Show dependency tree / graph
 
Reported: 2022-12-28 20:56 UTC by Andrew Fuerste-Henry
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Circulation function:

Attachments
Bug 32544: Remove flags as option from several patron form related system preferences (4.31 KB, patch)
2022-12-28 21:07 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 32544: Remove flags as option from several patron form related system preferences (4.37 KB, patch)
2022-12-28 21:33 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 32544: Remove flags as option from several patron form related system preferences (4.44 KB, patch)
2023-01-31 12:49 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2022-12-28 20:56:51 UTC 
Borrowers.flags should not be an option in the following syspref menus: PatronSelfModificationMandatoryField, PatronSelfRegistrationBorrowerMandatoryField, BorrowerMandatoryField, PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerUnwantedField

Because permissions aren't actually set via the borrower edit screens, these checkboxes have no real purpose or effect.
Comment 1 Katrin Fischer 2022-12-28 21:07:56 UTC 
Created attachment 144877 [details] [review]
Bug 32544: Remove flags as option from several patron form related system preferences

Because permissions aren't actually set via the patron edit
screens, these checkboxes have no real purpose or effect.

This removes flags from the selectable fields of the following
system preferences:

* PatronSelfModificationMandatoryField
* PatronSelfRegistrationBorrowerMandatoryField
* BorrowerMandatoryField
* PatronSelfModificationBorrowerUnwantedField
* PatronSelfRegistrationBorrowerUnwantedField

To test:
* Apply patch
* Verify that the checkbox for flags can no longer be set for
these preferences
Comment 2 ByWater Sandboxes 2022-12-28 21:33:29 UTC 
Created attachment 144880 [details] [review]
Bug 32544: Remove flags as option from several patron form related system preferences

Because permissions aren't actually set via the patron edit
screens, these checkboxes have no real purpose or effect.

This removes flags from the selectable fields of the following
system preferences:

* PatronSelfModificationMandatoryField
* PatronSelfRegistrationBorrowerMandatoryField
* BorrowerMandatoryField
* PatronSelfModificationBorrowerUnwantedField
* PatronSelfRegistrationBorrowerUnwantedField

To test:
* Apply patch
* Verify that the checkbox for flags can no longer be set for
these preferences

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Martin Renvoize (ashimema) 2023-01-31 12:49:50 UTC 
Created attachment 145852 [details] [review]
Bug 32544: Remove flags as option from several patron form related system preferences

Because permissions aren't actually set via the patron edit
screens, these checkboxes have no real purpose or effect.

This removes flags from the selectable fields of the following
system preferences:

* PatronSelfModificationMandatoryField
* PatronSelfRegistrationBorrowerMandatoryField
* BorrowerMandatoryField
* PatronSelfModificationBorrowerUnwantedField
* PatronSelfRegistrationBorrowerUnwantedField

To test:
* Apply patch
* Verify that the checkbox for flags can no longer be set for
these preferences

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-01-31 12:50:13 UTC 
Another nice fix, no regressions.. Passing QA.
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-07 13:59:32 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-02-08 16:53:09 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.