Bug 32566 - Don't show 'ILL request logs' button, when IllLog is turned off
Summary: Don't show 'ILL request logs' button, when IllLog is turned off
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-04 15:38 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11, 21.11.19


Attachments
Bug 32566: Don't show "ILL request log" when IllLog is disabled (2.22 KB, patch)
2023-02-09 21:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32566: Don't show "ILL request log" when IllLog is disabled (2.27 KB, patch)
2023-02-15 09:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 32566: Don't show "ILL request log" when IllLog is disabled (2.32 KB, patch)
2023-02-17 18:10 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-04 15:38:37 UTC
When the IllLog system preference is turned off, the 'ILL request log' will always be empty. We should not show the button when the system preference is turned off.
Comment 1 Katrin Fischer 2023-02-09 21:43:51 UTC
Created attachment 146454 [details] [review]
Bug 32566: Don't show "ILL request log" when IllLog is disabled

When the IllLog system preference is disabled there will be no
log to view and the log will always appear empty.

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
   https://wiki.koha-community.org/wiki/ILL_backends
3) Go to the ILL module and add a new request
4) The "ILL request log" entry in the toolbar should be visible
5) Turn off the IllLog system preference
6) Reload the page - the option should remain visible
7) Apply patch
8) Verify the link is now no longer visible after reload
9) Re-activate the IllLog
10) Verify the option now appears
Comment 2 David Nind 2023-02-15 09:25:13 UTC
Created attachment 146667 [details] [review]
Bug 32566: Don't show "ILL request log" when IllLog is disabled

When the IllLog system preference is disabled there will be no
log to view and the log will always appear empty.

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
   https://wiki.koha-community.org/wiki/ILL_backends
3) Go to the ILL module and add a new request
4) The "ILL request log" entry in the toolbar should be visible
5) Turn off the IllLog system preference
6) Reload the page - the option should remain visible
7) Apply patch
8) Verify the link is now no longer visible after reload
9) Re-activate the IllLog
10) Verify the option now appears

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Kyle M Hall 2023-02-17 18:10:07 UTC
Created attachment 146901 [details] [review]
Bug 32566: Don't show "ILL request log" when IllLog is disabled

When the IllLog system preference is disabled there will be no
log to view and the log will always appear empty.

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
   https://wiki.koha-community.org/wiki/ILL_backends
3) Go to the ILL module and add a new request
4) The "ILL request log" entry in the toolbar should be visible
5) Turn off the IllLog system preference
6) Reload the page - the option should remain visible
7) Apply patch
8) Verify the link is now no longer visible after reload
9) Re-activate the IllLog
10) Verify the option now appears

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-02-20 12:45:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-02-24 08:16:20 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 6 Lucas Gass 2023-03-01 14:31:23 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 7 Arthur Suzuki 2023-03-29 09:11:36 UTC
applied to 21.11.x for 21.11.19
Comment 8 wainuiwitikapark 2023-04-27 03:55:49 UTC
Not backported to 21.05.x