Bug 32567 - Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code'
Summary: Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Thibaud Guillot
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-04 16:09 UTC by Thibaud Guillot
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32567: Update unimarc_field_110.pl with some values (9.27 KB, patch)
2023-01-04 16:13 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 32567: Update unimarc_field_110.pl with some values (9.32 KB, patch)
2023-01-05 16:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32567: Update unimarc_field_110.pl with some values (9.37 KB, patch)
2023-02-05 13:07 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32567: (QA follow-up) Fix some labelling inconsistencies (9.97 KB, patch)
2023-02-05 13:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot 2023-01-04 16:09:03 UTC
Update value builder for unimarc_field_110 with some values
Comment 1 Thibaud Guillot 2023-01-04 16:13:28 UTC
Created attachment 145031 [details] [review]
Bug 32567: Update unimarc_field_110.pl with some values

'Script of title' values =>
e - b/c/d/e/f/g/h
i - d/e
j - f/g
l - f
n - b/c
o - a
p - a

'Translitteral code' values =>
'g' and 'h'
Comment 2 Thibaud Guillot 2023-01-04 16:16:07 UTC
I hope there is no translation error, if someone tells me I will correct it. I took the opportunity to reorder the different fields in alphabetical order, it is easier to find your way
Comment 3 Owen Leonard 2023-01-05 16:28:20 UTC
Created attachment 145065 [details] [review]
Bug 32567: Update unimarc_field_110.pl with some values

'Script of title' values =>
e - b/c/d/e/f/g/h
i - d/e
j - f/g
l - f
n - b/c
o - a
p - a

'Translitteral code' values =>
'g' and 'h'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2023-02-05 13:07:38 UTC
Created attachment 146209 [details] [review]
Bug 32567: Update unimarc_field_110.pl with some values

'Script of title' values =>
e - b/c/d/e/f/g/h
i - d/e
j - f/g
l - f
n - b/c
o - a
p - a

'Translitteral code' values =>
'g' and 'h'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-02-05 13:07:42 UTC
Created attachment 146210 [details] [review]
Bug 32567: (QA follow-up) Fix some labelling inconsistencies

This makes sure that the descriptions in the pull-downs always
match for selected/unselected.
This is not only for consistency, but will also ease translations
as simple things like an additional space will create a new
string to translate.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Thibaud Guillot 2023-02-06 08:26:51 UTC
(In reply to Katrin Fischer from comment #5)
> Created attachment 146210 [details] [review] [review]
> Bug 32567: (QA follow-up) Fix some labelling inconsistencies
> 
> This makes sure that the descriptions in the pull-downs always
> match for selected/unselected.
> This is not only for consistency, but will also ease translations
> as simple things like an additional space will create a new
> string to translate.
> 
> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Thanks Katrin
Comment 7 Tomás Cohen Arazi 2023-02-07 18:29:22 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-02-08 16:53:13 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass 2023-02-15 21:39:11 UTC
Doesn't apply cleanly to 22.05.x, no backport