Bug 32576 - ILL needs the page-section treatment
Summary: ILL needs the page-section treatment
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
: 32564 (view as bug list)
Depends on:
Blocks: 31757
  Show dependency treegraph
 
Reported: 2023-01-06 15:12 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32576: Move page-section outside of table include (5.85 KB, patch)
2023-01-06 15:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32576: Replace panels with page-sections (7.58 KB, patch)
2023-01-06 15:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32576: Move page-section outside of table include (5.90 KB, patch)
2023-01-16 20:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32576: Replace panels with page-sections (7.64 KB, patch)
2023-01-16 20:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32576: Move page-section outside of table include (6.02 KB, patch)
2023-02-27 11:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32576: Replace panels with page-sections (7.72 KB, patch)
2023-02-27 11:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32576: Move page-section outside of table include (6.10 KB, patch)
2023-02-28 14:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32576: Replace panels with page-sections (7.80 KB, patch)
2023-02-28 14:04 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-01-06 15:12:17 UTC
The ILL module is using panels when it should now use page-section cards instead.
Comment 1 Martin Renvoize 2023-01-06 15:34:35 UTC
Created attachment 145085 [details] [review]
Bug 32576: Move page-section outside of table include

This patch drops the superflous div from the ill-list-table include and
instead opts to wrap calls to it with a more appropriately positioned
div instead.
Comment 2 Martin Renvoize 2023-01-06 15:34:39 UTC
Created attachment 145086 [details] [review]
Bug 32576: Replace panels with page-sections
Comment 3 Katrin Fischer 2023-01-16 20:26:06 UTC
Almost missed this one - looks nice! 

We have a 'competing' patch on bug 32564, but I think I prefer the page-sections. 

Did you forget to set Needs Signoff or was there something missing here still?
Comment 4 Katrin Fischer 2023-01-16 20:44:48 UTC
Created attachment 145342 [details] [review]
Bug 32576: Move page-section outside of table include

This patch drops the superflous div from the ill-list-table include and
instead opts to wrap calls to it with a more appropriately positioned
div instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-01-16 20:44:52 UTC
Created attachment 145343 [details] [review]
Bug 32576: Replace panels with page-sections

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Martin Renvoize 2023-01-31 14:46:27 UTC
*** Bug 32564 has been marked as a duplicate of this bug. ***
Comment 7 Martin Renvoize 2023-02-27 11:45:10 UTC
Created attachment 147430 [details] [review]
Bug 32576: Move page-section outside of table include

This patch drops the superflous div from the ill-list-table include and
instead opts to wrap calls to it with a more appropriately positioned
div instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Martin Renvoize 2023-02-27 11:45:12 UTC
Created attachment 147431 [details] [review]
Bug 32576: Replace panels with page-sections

This patch replaces the bootstrap panels with the more modern koha
page-section cards layout.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Martin Renvoize 2023-02-27 11:45:32 UTC
Rebased, thanks for taking a look Jonathan.
Comment 10 Jonathan Druart 2023-02-28 14:04:21 UTC
Created attachment 147489 [details] [review]
Bug 32576: Move page-section outside of table include

This patch drops the superflous div from the ill-list-table include and
instead opts to wrap calls to it with a more appropriately positioned
div instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2023-02-28 14:04:24 UTC
Created attachment 147490 [details] [review]
Bug 32576: Replace panels with page-sections

This patch replaces the bootstrap panels with the more modern koha
page-section cards layout.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Tomás Cohen Arazi 2023-03-02 12:39:28 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 13 Matt Blenkinsop 2023-03-03 12:08:33 UTC
Nice work everyone!

Pushed to stable for 22.11.x