Bug 32585 - Followup on Bug 32583 - fix some variable references
Summary: Followup on Bug 32583 - fix some variable references
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Michael Hafen
QA Contact: Testopia
URL:
Keywords:
Depends on: 31315 32583
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-06 23:10 UTC by Michael Hafen
Modified: 2023-06-22 10:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32585 - followup on Bug 32583 - fix some variable references (1.41 KB, patch)
2023-01-06 23:13 UTC, Michael Hafen
Details | Diff | Splinter Review
Bug 32585 - followup on Bug 32583 - fix some variable references (1.42 KB, patch)
2023-01-12 00:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 32585: (bug 32583 follow-up) Fix some variable references (1.49 KB, patch)
2023-02-23 14:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hafen 2023-01-06 23:10:30 UTC
Two variable references need to be changed after Bug 32583 changed the item variable from a hash to an object.  One effects the host biblionumber, which isn't used in the template.  The other effects the Acquisition backet number.
Comment 1 Michael Hafen 2023-01-06 23:13:19 UTC
Created attachment 145115 [details] [review]
Bug 32585 - followup on Bug 32583 - fix some variable references

Bug 32583 change the $item variable from a hash to an object.  Trivial patch
to change some hash references to object method calls.
Comment 2 David Nind 2023-01-12 00:35:47 UTC
Created attachment 145228 [details] [review]
Bug 32585 - followup on Bug 32583 - fix some variable references

Bug 32583 change the $item variable from a hash to an object.  Trivial patch
to change some hash references to object method calls.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-01-12 00:37:40 UTC
Testing notes (using KTD):

1. I tested by first apply bug 32583 and then this bug.

2. I then repeated the test plan in bug 32583.

I hope this is sufficient, otherwise let me know if any other tests are required.
Comment 4 Jonathan Druart 2023-02-23 14:35:43 UTC
Created attachment 147236 [details] [review]
Bug 32585: (bug 32583 follow-up) Fix some variable references

Bug 32583 change the $item variable from a hash to an object.  Trivial patch
to change some hash references to object method calls.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-02-27 16:07:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-01 09:54:02 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-03-10 14:28:22 UTC
Missing dependency for 22.05.x, no backport.