Bug 32588 - Filters on top of 'Items with no checkouts' report are untranslatable
Summary: Filters on top of 'Items with no checkouts' report are untranslatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 32589
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-07 00:40 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32588: Make filters on 'items with no checkouts' report translatable (6.01 KB, patch)
2023-01-07 02:15 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32588: Make filters on 'items with no checkouts' report translatable (6.15 KB, patch)
2023-01-07 10:44 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 32588: Make filters on 'items with no checkouts' report translatable (6.22 KB, patch)
2023-01-31 13:08 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32588: (QA follow-up) Add missing filter (1.28 KB, patch)
2023-01-31 14:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-07 00:40:53 UTC
When you run the "items with no checkouts" report, on top you see something like:

Filtered on:

Doc Type = BK

limit = 10 

These are problematic in several ways:

* the labels are untranslatable
* BK and library code should be translated to their descriptions
* limit should be Limit
* Doc Type should be Item type
* Branch should be library
Comment 1 Katrin Fischer 2023-01-07 02:15:42 UTC
Created attachment 145124 [details] [review]
Bug 32588: Make filters on 'items with no checkouts' report translatable

This makes the filters on top of the 'items with no checkouts' report
translatable. The descriptions of the filters used the wrong terms and
were also pulled from the .pl file, making them untranslatable.

To test:
* Without patch: Run the 'items with no checkouts' report with various
  settigs.
* Verify, that the display on top doesn't use standard terminology
  Doc type = item type, Branch = library
* Apply patch
* Verify display is improved and standard terminology is used

If you know how to, you can also confirm strings show up nicely in
translations:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
Comment 2 Frédéric Demians 2023-01-07 10:44:21 UTC
Created attachment 145130 [details] [review]
Bug 32588: Make filters on 'items with no checkouts' report translatable

This makes the filters on top of the 'items with no checkouts' report
translatable. The descriptions of the filters used the wrong terms and
were also pulled from the .pl file, making them untranslatable.

To test:
* Without patch: Run the 'items with no checkouts' report with various
  settigs.
* Verify, that the display on top doesn't use standard terminology
  Doc type = item type, Branch = library
* Apply patch
* Verify display is improved and standard terminology is used

If you know how to, you can also confirm strings show up nicely in
translations:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Comment 3 Katrin Fischer 2023-01-07 13:45:53 UTC
Thank you, Frédéric!
Comment 4 Martin Renvoize 2023-01-31 13:08:40 UTC
Created attachment 145861 [details] [review]
Bug 32588: Make filters on 'items with no checkouts' report translatable

This makes the filters on top of the 'items with no checkouts' report
translatable. The descriptions of the filters used the wrong terms and
were also pulled from the .pl file, making them untranslatable.

To test:
* Without patch: Run the 'items with no checkouts' report with various
  settigs.
* Verify, that the display on top doesn't use standard terminology
  Doc type = item type, Branch = library
* Apply patch
* Verify display is improved and standard terminology is used

If you know how to, you can also confirm strings show up nicely in
translations:
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-01-31 13:09:05 UTC
All working as expected, Thanks Katrin.

Passing QA
Comment 6 Tomás Cohen Arazi 2023-01-31 14:07:24 UTC
Created attachment 145871 [details] [review]
Bug 32588: (QA follow-up) Add missing filter

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2023-01-31 14:08:21 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-01-31 18:11:29 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass 2023-02-03 22:13:47 UTC
Missing dependencies for 22.05.x, no backport.