Bug 32596 - Background jobs viewer not showing finished jobs
Summary: Background jobs viewer not showing finished jobs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 30982
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-09 14:09 UTC by Nick Clemens
Modified: 2023-12-28 20:42 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02,22.05.09


Attachments
Bug 32596: Filter jobs by enqueued on, not started on (1.74 KB, patch)
2023-01-09 14:10 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32596: Filter jobs by enqueued on, not started on (1.80 KB, patch)
2023-01-10 15:51 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32596: Filter jobs by enqueued on, not started on (1.87 KB, patch)
2023-01-10 16:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-01-09 14:09:08 UTC
It seems that the filters are based on 'started_on' - I think 'enqueued_on' makes more sense

To recreate:
1 - Do a bunch of stuff in the staff interface the will generate background jobs
2 - Wait a bit to make sure all the jobs are done
3 - Visit Admin->Jobs
4 - Note there is nothing shown
5 - uncheck 'Current jobs only' and 'Only include jobs started in the last hour'
6 - Note that nothing is shown, but header says '(filtered from X jobs)'
Comment 1 Nick Clemens 2023-01-09 14:10:33 UTC
Created attachment 145146 [details] [review]
Bug 32596: Filter jobs by enqueued on, not started on

To test:
1 - Do a bunch of stuff in the staff interface the will generate background jobs
2 - Wait a bit to make sure all the jobs are done
3 - Visit Admin->Jobs
4 - Note there is nothing shown
5 - uncheck 'Current jobs only' and 'Only include jobs started in the last hour'
6 - Note that nothing is shown, but header says '(filtered from X jobs)'
7 - Apply patch
8 - Reload table
9 - Confirm you can see the finished jobs now
Comment 2 ByWater Sandboxes 2023-01-10 15:51:49 UTC
Created attachment 145193 [details] [review]
Bug 32596: Filter jobs by enqueued on, not started on

To test:
1 - Do a bunch of stuff in the staff interface the will generate background jobs
2 - Wait a bit to make sure all the jobs are done
3 - Visit Admin->Jobs
4 - Note there is nothing shown
5 - uncheck 'Current jobs only' and 'Only include jobs started in the last hour'
6 - Note that nothing is shown, but header says '(filtered from X jobs)'
7 - Apply patch
8 - Reload table
9 - Confirm you can see the finished jobs now

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Andrew Fuerste-Henry 2023-01-10 15:57:33 UTC
In testing, batch item and bib modification jobs showed up when complete without the patch. Resetting ES mappings created a job that did not show without the patch.
Comment 4 Jonathan Druart 2023-01-10 16:37:10 UTC
This is a bug but somewhere else. started_on is always null.
Comment 5 Jonathan Druart 2023-01-10 16:48:54 UTC
(In reply to Jonathan Druart from comment #4)
> This is a bug but somewhere else. started_on is always null.

I do not longer recreate that (?)
Comment 6 Jonathan Druart 2023-01-10 16:50:24 UTC
Created attachment 145199 [details] [review]
Bug 32596: Filter jobs by enqueued on, not started on

To test:
1 - Do a bunch of stuff in the staff interface the will generate background jobs
2 - Wait a bit to make sure all the jobs are done
3 - Visit Admin->Jobs
4 - Note there is nothing shown
5 - uncheck 'Current jobs only' and 'Only include jobs started in the last hour'
6 - Note that nothing is shown, but header says '(filtered from X jobs)'
7 - Apply patch
8 - Reload table
9 - Confirm you can see the finished jobs now

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Tomás Cohen Arazi 2023-01-11 23:56:08 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-01-13 16:25:15 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass 2023-01-24 18:55:20 UTC
Backported to 22.05.x for upcoming 22.05.09
Comment 10 Arthur Suzuki 2023-01-26 13:35:52 UTC
depends on 30982 not present on 21.11.x branch.
won't backport