Bug 32597 - Article requests not stacking in patron view
Summary: Article requests not stacking in patron view
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-09 18:02 UTC by Kelly McElligott
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02,22.05.09


Attachments
Bug 32597: Fix table display of OPAC article requests (11.81 KB, patch)
2023-01-09 18:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32597: Fix table display of OPAC article requests (11.86 KB, patch)
2023-01-09 19:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32597: Fix table display of OPAC article requests (11.96 KB, patch)
2023-01-13 09:35 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2023-01-09 18:02:17 UTC
When a patron has requested multiple article requests and they are listed in the Article Request tab, opac-user.pl (Summary Page), these requests are not stacking on top of each other, rather they are listed horizontally. The article requests should be listed out in a list format, as it is done in Holds, Purchase Suggestions etc.
Comment 1 Lucas Gass 2023-01-09 18:15:29 UTC
Created attachment 145157 [details] [review]
Bug 32597: Fix table display of OPAC article requests

To test:
1. Enable ArticleRequests
2. Make some requests (two or more) on the OPAC and go to the user summary.
3. The table rows display horizontally.
4. Apply patch
5. Try step 2 again, the table should display correctly.

Note: I made some whitespace changes to make the markup look correct.
Comment 2 Lucas Gass 2023-01-09 18:16:25 UTC
<tr> in this case should be inside the TT loop
Comment 3 Owen Leonard 2023-01-09 19:23:02 UTC
Created attachment 145160 [details] [review]
Bug 32597: Fix table display of OPAC article requests

To test:
1. Enable ArticleRequests
2. Make some requests (two or more) on the OPAC and go to the user
   summary.
3. The table rows display horizontally.
4. Apply patch
5. Try step 2 again, the table should display correctly.

Note: I made some whitespace changes to make the markup look correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Marcel de Rooy 2023-01-13 09:35:21 UTC
Created attachment 145254 [details] [review]
Bug 32597: Fix table display of OPAC article requests

To test:
1. Enable ArticleRequests
2. Make some requests (two or more) on the OPAC and go to the user
   summary.
3. The table rows display horizontally.
4. Apply patch
5. Try step 2 again, the table should display correctly.

Note: I made some whitespace changes to make the markup look correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Martin Renvoize 2023-01-18 15:50:32 UTC
Nice work everyone!

Pushed to 23.05.x for the next release
Comment 6 Jacob O'Mara 2023-01-18 17:06:09 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Lucas Gass 2023-01-24 19:04:14 UTC
Backported to 22.05.x for upcoming 22.05.09
Comment 8 Arthur Suzuki 2023-01-26 13:43:44 UTC
depends on new features (Recalls) which is not present in 21.11.x.
Won't backport.