Bug 32606 - Revert Flatpickr style changes made in Bug 31943
Summary: Revert Flatpickr style changes made in Bug 31943
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
: 32157 32210 32259 (view as bug list)
Depends on: 31943
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-10 19:32 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Circulation function:


Attachments
Bug 32606: Revert Flatpickr style changes made in Bug 31943 (1.25 KB, patch)
2023-01-10 19:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32606: Revert Flatpickr style changes made in Bug 31943 (1.29 KB, patch)
2023-01-10 23:59 UTC, David Nind
Details | Diff | Splinter Review
Bug 32606: Revert Flatpickr style changes made in Bug 31943 (1.35 KB, patch)
2023-02-05 13:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-10 19:32:04 UTC
One of the changes made by Bug 31943 was to the width of Flatpickr inputs, but those changes only work in some forms and layouts. In others situations the input stretches to the width of the container.

I propose that we undo this one-line change until a better solution can be found.
Comment 1 Owen Leonard 2023-01-10 19:46:29 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-01-10 23:59:44 UTC
Created attachment 145206 [details] [review]
Bug 32606: Revert Flatpickr style changes made in Bug 31943

This patch removes the CSS controlling the width of a Flatpickr date
input. The side-effects of this change are worse than the problem the
change was intended to fix.

To test, apply the patch and rebuild the staff interface CSS.

Check pages which are referenced in bugs caused by Bug 31943:

- The holds page (Bug 32259)
- Checking out when specifying a date due in the past (Bug 32210)
- Circulation -> Renew (Bug 32157)

Flatpickr inputs should look correct.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-02-05 13:15:19 UTC
Created attachment 146211 [details] [review]
Bug 32606: Revert Flatpickr style changes made in Bug 31943

This patch removes the CSS controlling the width of a Flatpickr date
input. The side-effects of this change are worse than the problem the
change was intended to fix.

To test, apply the patch and rebuild the staff interface CSS.

Check pages which are referenced in bugs caused by Bug 31943:

- The holds page (Bug 32259)
- Checking out when specifying a date due in the past (Bug 32210)
- Circulation -> Renew (Bug 32157)

Flatpickr inputs should look correct.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-02-05 13:16:13 UTC
*** Bug 32210 has been marked as a duplicate of this bug. ***
Comment 5 Katrin Fischer 2023-02-05 13:16:30 UTC
*** Bug 32157 has been marked as a duplicate of this bug. ***
Comment 6 Katrin Fischer 2023-02-05 13:16:51 UTC
*** Bug 32259 has been marked as a duplicate of this bug. ***
Comment 7 Tomás Cohen Arazi (tcohen) 2023-02-06 21:36:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-02-07 15:18:30 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Lucas Gass (lukeg) 2023-02-14 22:28:33 UTC
Not needed in 22.05.x