Several acquisitions templates need to have main content wrapped in a "page-section" container. - acqui/edi_ean.tt - acqui/edifactmsgs.tt - acqui/histsearch.tt - acqui/lateorders.tt - acqui/newordersubscription.tt - acqui/newordersuggestion.tt - acqui/ordered.tt - acqui/spent.tt - acqui/z3950_search.tt
Created attachment 145240 [details] [review] Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of cataloging plugins which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results
Created attachment 145241 [details] [review] Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of acquisitions page which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results
Created attachment 145247 [details] [review] Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of acquisitions page which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. EDIFACT setup: . Enable EDIFACT . Administration > Acquisition parameters: - EDI accounts > New account > Add details (including 'Orders enabled', details don't need to be valid) - Library EANs > New EAN 2. Suggestions: add a suggestion and change the status to accepted 3. Add to order from a subscription: set up a serial first
Created attachment 145338 [details] [review] Bug 32616: Add 'page-section' to various acquisitions pages This patch adds a "page-section" container div around the main section of acquisitions page which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Basket -> Create EDIFACT order - Acquisitions -> EDIFACT messages - Acquisitions -> Orders search -> Results - Acquisitions -> Late orders - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> All available funds -> Ordered - Acquisitions -> All available funds -> Spent - Acquisitions -> Vendor -> Add to basket -> From an external source -> Results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Tiny note/question: On the EDIFACT messages page there is a page-section with a dialog box within: There are no EDIFACT messages. On other pages we have the alerts/dialogs outside the page section. Maybe we should move this above the page section and make sure the empty page section doesn't display?
Nice work everyone! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to stable for 22.11.x