Bug 32660 - Use template wrapper for basket groups tabs
Summary: Use template wrapper for basket groups tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-17 19:42 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32660: Use template wrapper for basket groups tabs (3.61 KB, patch)
2023-01-17 20:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32660: (follow-up) Use more unique variable name to avoid collisions (1.47 KB, patch)
2023-01-20 16:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32660: Use template wrapper for basket groups tabs (3.66 KB, patch)
2023-01-28 20:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 32660: (follow-up) Use more unique variable name to avoid collisions (1.51 KB, patch)
2023-01-28 20:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 32660: Use template wrapper for basket groups tabs (3.71 KB, patch)
2023-02-05 12:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32660: (follow-up) Use more unique variable name to avoid collisions (1.57 KB, patch)
2023-02-05 12:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-17 19:42:04 UTC
Continuing the work of Bug 32571, the basket groups template should be revised to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-01-17 20:08:15 UTC
Created attachment 145371 [details] [review]
Bug 32660: Use template wrapper for basket groups tabs

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the basket groups page.

To test you must have at least one active vendor, one or more closed
baskets under that vendor, and at least one basket group containing a
closed basket.

Apply the patch and go to Acquisitions -> Vendor -> Basket groups.

You should see two tabs, "Open" and "Closed." The tabs should look
correct and work correctly.
Comment 2 Owen Leonard 2023-01-20 16:25:16 UTC
Created attachment 145538 [details] [review]
Bug 32660: (follow-up) Use more unique variable name to avoid collisions
Comment 3 David Nind 2023-01-28 20:21:25 UTC
Created attachment 145790 [details] [review]
Bug 32660: Use template wrapper for basket groups tabs

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the basket groups page.

To test you must have at least one active vendor, one or more closed
baskets under that vendor, and at least one basket group containing a
closed basket.

Apply the patch and go to Acquisitions -> Vendor -> Basket groups.

You should see two tabs, "Open" and "Closed." The tabs should look
correct and work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-01-28 20:21:30 UTC
Created attachment 145791 [details] [review]
Bug 32660: (follow-up) Use more unique variable name to avoid collisions

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2023-02-05 12:46:07 UTC
Created attachment 146204 [details] [review]
Bug 32660: Use template wrapper for basket groups tabs

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the basket groups page.

To test you must have at least one active vendor, one or more closed
baskets under that vendor, and at least one basket group containing a
closed basket.

Apply the patch and go to Acquisitions -> Vendor -> Basket groups.

You should see two tabs, "Open" and "Closed." The tabs should look
correct and work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-02-05 12:46:11 UTC
Created attachment 146205 [details] [review]
Bug 32660: (follow-up) Use more unique variable name to avoid collisions

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-02-07 18:29:45 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-02-08 16:53:31 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.