Bug 32662 - Use template wrapper for item circulation alerts page
Summary: Use template wrapper for item circulation alerts page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency tree / graph
 
Reported: 2023-01-17 20:48 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Circulation function:

Attachments
Bug 32662: Use template wrapper for item circulation alerts page (3.61 KB, patch)
2023-01-17 20:53 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32662: Use template wrapper for item circulation alerts page (3.35 KB, patch)
2023-01-20 16:41 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32662: Use template wrapper for item circulation alerts page (3.40 KB, patch)
2023-01-28 20:09 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32662: Use template wrapper for item circulation alerts page (3.46 KB, patch)
2023-02-05 12:43 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-17 20:48:26 UTC 
Continuing the work of Bug 32571, the item circulation alerts template should be revised to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-01-17 20:53:43 UTC 
Created attachment 145373 [details] [review]
Bug 32662: Use template wrapper for item circulation alerts page

This patch implements the template WRAPPER system (see Bug 32571) for
building tabs on the item circulation alerts page.

To test, apply the patch and go to Administration -> Item
circulation alerts. There should be two tabs, "Checkout" and "Check-in"
which work correctly.
Comment 2 Owen Leonard 2023-01-20 16:41:43 UTC 
Created attachment 145541 [details] [review]
Bug 32662: Use template wrapper for item circulation alerts page

This patch implements the template WRAPPER system (see Bug 32571)
for building tabs on the item circulation alerts page.

To test, apply the patch and go to Administration -> Item
circulation alerts. There should be two tabs, "Checkout" and
"Check-in" which work correctly.
Comment 3 David Nind 2023-01-28 20:09:08 UTC 
Created attachment 145789 [details] [review]
Bug 32662: Use template wrapper for item circulation alerts page

This patch implements the template WRAPPER system (see Bug 32571)
for building tabs on the item circulation alerts page.

To test, apply the patch and go to Administration -> Item
circulation alerts. There should be two tabs, "Checkout" and
"Check-in" which work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-02-05 12:43:36 UTC 
Created attachment 146203 [details] [review]
Bug 32662: Use template wrapper for item circulation alerts page

This patch implements the template WRAPPER system (see Bug 32571)
for building tabs on the item circulation alerts page.

To test, apply the patch and go to Administration -> Item
circulation alerts. There should be two tabs, "Checkout" and
"Check-in" which work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-07 18:29:58 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-02-08 16:53:37 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.