warnPrefRequireChoosingExistingAuthority won't display on about.pl if it's the only problem since the top level condition has a typo. It's written as warnRequireChoosingExistingAuthority
Created attachment 145382 [details] [review] Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference
Created attachment 145391 [details] [review] Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Testing notes: Both RequireChoosingExistingAuthority and AutoCreateAuthorites should be disabled in system preferences. If you have any other warnings under the "System Information" tab you must resolve them to reproduce the error.
Happy for someone to take over this one. Seemed like a simple fix but also vulnerable to needing a lot of rebasing before getting pushed.
Maybe I should just do it. Just feeling overwhelmed by the amount to do...
Created attachment 147279 [details] [review] Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 147399 [details] [review] Bug 32665: Fix typo in template condition This patch fixes a typo in a template condition so that the about.pl warning about RequireChoosingExistingAuthority is shown when it's the only warning to display Test plan: 0. Don't apply the patch yet 1. Go to http://localhost:8081/cgi-bin/koha/about.pl 2. Note that "No warnings" is shown 3. Apply the patch 4. Go to http://localhost:8081/cgi-bin/koha/about.pl 5. Note that there is a heading for "Warnings regarding the system configuration" and a specific warning about the "RequireChoosingExistingAuthority" system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release