Bug 32665 - warnPrefRequireChoosingExistingAuthority condition incorrect in about.pl
Summary: warnPrefRequireChoosingExistingAuthority condition incorrect in about.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-18 03:19 UTC by David Cook
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32665: Fix typo in template condition (3.04 KB, patch)
2023-01-18 04:40 UTC, David Cook
Details | Diff | Splinter Review
Bug 32665: Fix typo in template condition (3.09 KB, patch)
2023-01-18 12:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32665: Fix typo in template condition (3.32 KB, patch)
2023-02-23 23:23 UTC, David Cook
Details | Diff | Splinter Review
Bug 32665: Fix typo in template condition (3.38 KB, patch)
2023-02-24 20:22 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2023-01-18 03:19:52 UTC
warnPrefRequireChoosingExistingAuthority won't display on about.pl if it's the only problem since the top level condition has a typo. It's written as warnRequireChoosingExistingAuthority
Comment 1 David Cook 2023-01-18 04:40:19 UTC
Created attachment 145382 [details] [review]
Bug 32665: Fix typo in template condition

This patch fixes a typo in a template condition so that
the about.pl warning about RequireChoosingExistingAuthority is
shown when it's the only warning to display

Test plan:
0. Don't apply the patch yet
1. Go to http://localhost:8081/cgi-bin/koha/about.pl
2. Note that "No warnings" is shown
3. Apply the patch
4. Go to http://localhost:8081/cgi-bin/koha/about.pl
5. Note that there is a heading for "Warnings regarding the
system configuration" and a specific warning about the
"RequireChoosingExistingAuthority" system preference
Comment 2 Owen Leonard 2023-01-18 12:23:01 UTC
Created attachment 145391 [details] [review]
Bug 32665: Fix typo in template condition

This patch fixes a typo in a template condition so that
the about.pl warning about RequireChoosingExistingAuthority is
shown when it's the only warning to display

Test plan:
0. Don't apply the patch yet
1. Go to http://localhost:8081/cgi-bin/koha/about.pl
2. Note that "No warnings" is shown
3. Apply the patch
4. Go to http://localhost:8081/cgi-bin/koha/about.pl
5. Note that there is a heading for "Warnings regarding the
system configuration" and a specific warning about the
"RequireChoosingExistingAuthority" system preference

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2023-01-18 12:28:28 UTC
Testing notes: Both RequireChoosingExistingAuthority and AutoCreateAuthorites should be disabled in system preferences.

If you have any other warnings under the "System Information" tab you must resolve them to reproduce the error.
Comment 4 David Cook 2023-02-23 22:43:39 UTC
Happy for someone to take over this one. Seemed like a simple fix but also vulnerable to needing a lot of rebasing before getting pushed.
Comment 5 David Cook 2023-02-23 23:16:13 UTC
Maybe I should just do it. Just feeling overwhelmed by the amount to do...
Comment 6 David Cook 2023-02-23 23:23:48 UTC
Created attachment 147279 [details] [review]
Bug 32665: Fix typo in template condition

This patch fixes a typo in a template condition so that
the about.pl warning about RequireChoosingExistingAuthority is
shown when it's the only warning to display

Test plan:
0. Don't apply the patch yet
1. Go to http://localhost:8081/cgi-bin/koha/about.pl
2. Note that "No warnings" is shown
3. Apply the patch
4. Go to http://localhost:8081/cgi-bin/koha/about.pl
5. Note that there is a heading for "Warnings regarding the
system configuration" and a specific warning about the
"RequireChoosingExistingAuthority" system preference

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Nick Clemens 2023-02-24 20:22:31 UTC
Created attachment 147399 [details] [review]
Bug 32665: Fix typo in template condition

This patch fixes a typo in a template condition so that
the about.pl warning about RequireChoosingExistingAuthority is
shown when it's the only warning to display

Test plan:
0. Don't apply the patch yet
1. Go to http://localhost:8081/cgi-bin/koha/about.pl
2. Note that "No warnings" is shown
3. Apply the patch
4. Go to http://localhost:8081/cgi-bin/koha/about.pl
5. Note that there is a heading for "Warnings regarding the
system configuration" and a specific warning about the
"RequireChoosingExistingAuthority" system preference

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-02-24 20:56:16 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-03-02 11:39:19 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release