It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the "Alternate address" or "Contact information" fields (like the "Address" field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on "Add guarantor" 4. Search for the patron 2 5. Click on "Select" --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor
Created attachment 145403 [details] [review] Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the Address field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on Select --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor
Created attachment 145404 [details] [review] Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the 'Address' field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on 'Select' --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor
Created attachment 145490 [details] [review] Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the 'Address' field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on 'Select' --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 145880 [details] [review] Bug 32675: Cannot add a guarantor when there is a single quote in the guarantor attributes It's impossible to select a guarantor when there is a single quote in the guarantor attributes. This patch allows to add a guarantor even if there is a single quote in guarantor attributes. Test plan 1. Find two patrons: - Patron 1 = guarantee - Patron 2 = guarantor 2. In the patron 2 account, add a single quote in one of the 'Alternate address' or 'Contact information' fields (like the 'Address' field) for example type «L'Aqueduc» in the field and save 3. Edit the patron 1 and click on 'Add guarantor' 4. Search for the patron 2 5. Click on 'Select' --> Nothing happens 6. Apply the patch 9. repeat step 3, 4 and 5 10. Now Patron 2 is added as guarantor Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com>
Created attachment 147169 [details] [review] Bug 32675: [alternative patch] Fix guarantor selection when simple quote present
I think this patch is less hazardous, we let the escape to JS internal.
Created attachment 147699 [details] [review] Bug 32675: [alternative patch] Fix guarantor selection when simple quote present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 147727 [details] [review] Bug 32675: [alternative patch] Fix guarantor selection when simple quote present Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Lucas, can this be back ported to 22.5? I can't expect our staff to do the gymnastics required to get around this until 22.11.
Backported to 22.05.x for upcoming 22.05.11
(In reply to Lucas Gass from comment #12) > Backported to 22.05.x for upcoming 22.05.11 That is good news. Thanks for doing this!
This one doesn't apply cleanly on 21.11, conflicts is not trivial to fix. Won't backport unless patch provided
*** Bug 32233 has been marked as a duplicate of this bug. ***