Bug 32676 - EDI message status uses varying case, breaking EDI status block
Summary: EDI message status uses varying case, breaking EDI status block
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL: https://github.com/bywatersolutions/b...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-18 19:08 UTC by Kyle M Hall
Modified: 2024-02-27 10:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 32676: EDI message status uses varying case, breaking EDI status block (2.04 KB, patch)
2023-01-18 19:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 32676: EDI message status uses varying case, breaking EDI status block (2.11 KB, patch)
2023-01-27 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-01-18 19:08:50 UTC
Edifact status appear to vary between all lower case and being capitalized. This breaks the switch in the edi_status block of the basket.tt template. We should make this switch case-insensitive.
Comment 1 Kyle M Hall 2023-01-18 19:10:53 UTC
Created attachment 145405 [details] [review]
Bug 32676: EDI message status uses varying case, breaking EDI status block

Edifact status appear to vary between all lower case and being capitalized. This breaks the switch in the edi_status block of the basket.tt template. We should make this switch case-insensitive.

Test Plan:
1) View the basket for a sent EDI order, not the Sent status does not
   display.
2) Apply this patch
3) Reload the page, note the status is now visible!
Comment 2 Martin Renvoize 2023-01-27 15:42:34 UTC
Created attachment 145758 [details] [review]
Bug 32676: EDI message status uses varying case, breaking EDI status block

Edifact status appear to vary between all lower case and being capitalized.
This breaks the switch in the edi_status block of the basket.tt template.
 We should make this switch case-insensitive.

Test Plan:
1) View the basket for a sent EDI order, not the Sent status does not
   display.
2) Apply this patch
3) Reload the page, note the status is now visible!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-01-27 15:43:21 UTC
All works as expected, nice clean fix.

Going straight for QA here.

Passing.
Comment 4 Tomás Cohen Arazi 2023-01-27 19:09:19 UTC
Please rebase.
Comment 5 Kyle M Hall 2023-01-31 17:52:05 UTC
I've been hit with the git-bz unicode error again, so here's the patch: https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_32676
Comment 6 Tomás Cohen Arazi 2023-02-03 13:14:56 UTC
Please rebase.
Comment 7 Kyle M Hall 2023-09-20 16:07:16 UTC
(In reply to Tomás Cohen Arazi from comment #6)
> Please rebase.

Rebased! Code is available at:
https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_32676
Comment 8 Victor Grousset/tuxayo 2023-09-26 15:04:49 UTC
(should have been switched back to PQA instead of Signed Off)
Comment 9 Tomás Cohen Arazi 2023-10-04 13:44:53 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-10-06 00:25:51 UTC
Pushed to 23.05.x for 23.05.05
Comment 11 Matt Blenkinsop 2023-10-17 17:24:24 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x