Bug 32679 - CSS class article-request-title is doubled up in article requests list in staff patron account
Summary: CSS class article-request-title is doubled up in article requests list in sta...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-01-19 08:10 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19


Attachments
Bug 32679: Use different CSS classes for titles of article requests in staff interface (2.13 KB, patch)
2023-01-20 13:57 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32679: Use different CSS classes for titles of article requests in staff interface (2.18 KB, patch)
2023-01-20 14:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32679: Use different CSS classes for titles of article requests in staff interface (2.26 KB, patch)
2023-02-23 10:28 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-19 08:10:57 UTC
The CSS class article-request-title is used for the title of the host and also for the column with the article title. So if you are not careful, things will get mixed up. The classes for 2 different things should be differently named.

* Activate article requests in system preferences
* Make sure article requests are allowed in circulation conditions
* Make an article request for a record in the OPAC
* Check the display in the patron account for the article request
Comment 1 Katrin Fischer 2023-01-20 13:40:43 UTC
This is already fixed in master on the OPAC side:

<td class="article-request-record-title">
[% INCLUDE 'biblio-title.inc' biblio=ar.biblio link=> 1 %]
Comment 2 Katrin Fischer 2023-01-20 13:57:06 UTC
Created attachment 145511 [details] [review]
Bug 32679: Use different CSS classes for titles of article requests in staff interface

The class article-request-title was used for the column with the article title as
well as for the link with the record title. This could cause some confusion when
changing the table with CSS. This patch makes it so different CSS classes are used for each.

To test:
* Activate article requests in system preferences
* Make sure circulation conditions have article requets = yes
* Create an article request in staff or OPAC
* View the list of article requests in the patron account in staff
* Add the following line to IntranetUserCSS:
  .article-request-title { display:none; }
* Verify the Title column and the title from Record title (first column)
  have vanished.
* Apply patch: now only the column should vanish, Record title shoudl remain
  visible
* If you want: Verify that the record title has a differently named class now.
Comment 3 Katrin Fischer 2023-01-20 13:57:41 UTC
Note: I pondered also using biblio-title.inc here, but in the patron account the title links to the article request page and not to the detail page. I didn't find a way to do that using the include.
Comment 4 Owen Leonard 2023-01-20 14:19:32 UTC
Created attachment 145515 [details] [review]
Bug 32679: Use different CSS classes for titles of article requests in staff interface

The class article-request-title was used for the column with the
article title as well as for the link with the record title. This could
cause some confusion when changing the table with CSS. This patch makes
it so different CSS classes are used for each.

To test:
* Activate article requests in system preferences
* Make sure circulation conditions have article requets = yes
* Create an article request in staff or OPAC
* View the list of article requests in the patron account in staff
* Add the following line to IntranetUserCSS:
  .article-request-title { display:none; }
* Verify the Title column and the title from Record title (first column)
  have vanished.
* Apply patch: now only the column should vanish, Record title shoudl remain
  visible
* If you want: Verify that the record title has a differently named
  class now.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Jonathan Druart 2023-02-23 10:28:54 UTC
Created attachment 147216 [details] [review]
Bug 32679: Use different CSS classes for titles of article requests in staff interface

The class article-request-title was used for the column with the
article title as well as for the link with the record title. This could
cause some confusion when changing the table with CSS. This patch makes
it so different CSS classes are used for each.

To test:
* Activate article requests in system preferences
* Make sure circulation conditions have article requets = yes
* Create an article request in staff or OPAC
* View the list of article requests in the patron account in staff
* Add the following line to IntranetUserCSS:
  .article-request-title { display:none; }
* Verify the Title column and the title from Record title (first column)
  have vanished.
* Apply patch: now only the column should vanish, Record title shoudl remain
  visible
* If you want: Verify that the record title has a differently named
  class now.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Tomás Cohen Arazi 2023-03-06 17:47:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-09 09:48:24 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-03-14 20:15:54 UTC
Backpoprted to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-30 07:42:11 UTC
applied to 21.11 for 21.11.19
Comment 10 wainuiwitikapark 2023-04-27 05:53:38 UTC
Not backported to 21.05.x