Bug 32685 - Display incorrect when matching authority records during import
Summary: Display incorrect when matching authority records during import
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low normal with 10 votes (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
: 32579 (view as bug list)
Depends on: 22785
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-19 20:45 UTC by Nick Clemens
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11


Attachments
Bug 32685: Correct authority match display on import (3.41 KB, patch)
2023-01-19 20:49 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32685: Correct authority match display on import (3.47 KB, patch)
2023-01-20 17:40 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32685: Correct authority match display on import (3.54 KB, patch)
2023-02-23 09:55 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-01-19 20:45:20 UTC
Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios

To recreate:
1 - Export some authority records form Koha
2 - Create a matching rule based on 'Local-number' and field 001
3 - Stage the records for import using above rule
4 - Note the match links point to authorities, but the citations point to biblios
Comment 1 Nick Clemens 2023-01-19 20:49:02 UTC
Created attachment 145495 [details] [review]
Bug 32685: Correct authority match display on import

Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios

To test:
1 - Export some authority records form Koha
2 - Create a matching rule based on 'Local-number' and field 001
3 - Stage the records for import using above rule
4 - Note the match links point to authorities, but the citations point to biblios
5 - Apply patch
6 - Reload the page
7 - Confirm the links have the correct text
Comment 2 ByWater Sandboxes 2023-01-20 17:40:13 UTC
Created attachment 145546 [details] [review]
Bug 32685: Correct authority match display on import

Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios

To test:
1 - Export some authority records form Koha
2 - Create a matching rule based on 'Local-number' and field 001
3 - Stage the records for import using above rule
4 - Note the match links point to authorities, but the citations point to biblios
5 - Apply patch
6 - Reload the page
7 - Confirm the links have the correct text

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Jonathan Druart 2023-02-23 09:55:09 UTC
Created attachment 147210 [details] [review]
Bug 32685: Correct authority match display on import

Bug 22785 updated the import records table, but mixed javascript variables and template toolkit, this means all matches are treated as biblios

To test:
1 - Export some authority records form Koha
2 - Create a matching rule based on 'Local-number' and field 001
3 - Stage the records for import using above rule
4 - Note the match links point to authorities, but the citations point to biblios
5 - Apply patch
6 - Reload the page
7 - Confirm the links have the correct text

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-02-23 09:55:32 UTC
I didn't test, trusting author and tester. The change makes sense.
Comment 5 Tomás Cohen Arazi 2023-02-27 14:42:29 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Alexis 2023-02-28 18:04:53 UTC
*** Bug 32579 has been marked as a duplicate of this bug. ***
Comment 7 Matt Blenkinsop 2023-03-01 09:32:28 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-03-10 14:06:27 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-29 12:54:21 UTC
dependency not met, won't backport to 21.11