Bug 32688 - Convert recalls awaiting pickup tabs to Bootstrap
Summary: Convert recalls awaiting pickup tabs to Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 29226 32683
  Show dependency tree / graph
 
Reported: 2023-01-20 11:54 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10
Circulation function:

Attachments
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap (18.38 KB, patch)
2023-01-20 12:06 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap (18.43 KB, patch)
2023-01-22 17:20 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap (18.43 KB, patch)
2023-01-22 17:21 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap (18.49 KB, patch)
2023-01-25 01:46 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-20 11:54:45 UTC 
The recalls awaiting pickup page have a set of jQueryUI tabs which should be converted to Bootstrap.
Comment 1 Owen Leonard 2023-01-20 12:06:54 UTC 
Created attachment 145508 [details] [review]
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap

This patch updates the recalls awaiting pickup template
(recalls_waiting.tt) to replace a set of jQueryUI tabs. They are
converted to Bootstrap in order to complete Bug 29226.

To test, apply the patch and make sure the "UseRecalls" system
preference is enabled.

- Go to Circulation -> Recalls awaiting pickup.
- You should see two tabs, "Recalls waiting" and "Recalls waiting over X
  days."
- The tabs should look correct and work correctly.
Comment 2 David Nind 2023-01-22 17:20:58 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-01-22 17:21:52 UTC 
Created attachment 145566 [details] [review]
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap

This patch updates the recalls awaiting pickup template
(recalls_waiting.tt) to replace a set of jQueryUI tabs. They are
converted to Bootstrap in order to complete Bug 29226.

To test, apply the patch and make sure the "UseRecalls" system
preference is enabled.

- Go to Circulation -> Recalls awaiting pickup.
- You should see two tabs, "Recalls waiting" and "Recalls waiting over X
  days."
- The tabs should look correct and work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lucas Gass (lukeg) 2023-01-25 01:45:19 UTC 
Changes look good, QA script is happy, HTML is all valid. Passing QA here.
Comment 5 Lucas Gass (lukeg) 2023-01-25 01:46:21 UTC 
Created attachment 145643 [details] [review]
Bug 32688: Convert recalls awaiting pickup tabs to Bootstrap

This patch updates the recalls awaiting pickup template
(recalls_waiting.tt) to replace a set of jQueryUI tabs. They are
converted to Bootstrap in order to complete Bug 29226.

To test, apply the patch and make sure the "UseRecalls" system
preference is enabled.

- Go to Circulation -> Recalls awaiting pickup.
- You should see two tabs, "Recalls waiting" and "Recalls waiting over X
  days."
- The tabs should look correct and work correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-01-30 18:11:03 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-02-01 15:19:42 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-02-03 22:21:33 UTC 
Backported to 22.05.x for upcoming 22.05.10
Comment 9 Arthur Suzuki 2023-02-17 09:58:48 UTC 
Recalls not available in 21.11.x.
Not backporting