Bug 32690 - Reindent the serial collection template
Summary: Reindent the serial collection template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-20 16:59 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32690: Reindent the serial collection template (37.00 KB, patch)
2023-01-20 17:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32690: (follow-up) Add markup comments (5.21 KB, patch)
2023-01-20 17:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32690: Reindent the serial collection template (37.05 KB, patch)
2023-01-27 20:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 32690: (follow-up) Add markup comments (5.26 KB, patch)
2023-01-27 20:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 32690: Reindent the serial collection template (37.10 KB, patch)
2023-01-30 21:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32690: (follow-up) Add markup comments (5.32 KB, patch)
2023-01-30 21:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-20 16:59:30 UTC
I would like to reformat the serial collection template (serials-collection.tt) in the staff interface so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2023-01-20 17:11:29 UTC
Created attachment 145543 [details] [review]
Bug 32690: Reindent the serial collection template

This patch reindents the serial collection template so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and go to Serials -> Subscription detail ->
Serial collection. Everything should look normal. All tabs should work
correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.
Comment 2 Owen Leonard 2023-01-20 17:11:33 UTC
Created attachment 145544 [details] [review]
Bug 32690: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 David Nind 2023-01-27 20:06:13 UTC
Created attachment 145774 [details] [review]
Bug 32690: Reindent the serial collection template

This patch reindents the serial collection template so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and go to Serials -> Subscription detail ->
Serial collection. Everything should look normal. All tabs should work
correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-01-27 20:06:18 UTC
Created attachment 145775 [details] [review]
Bug 32690: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2023-01-30 21:43:33 UTC
Created attachment 145817 [details] [review]
Bug 32690: Reindent the serial collection template

This patch reindents the serial collection template so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and go to Serials -> Subscription detail ->
Serial collection. Everything should look normal. All tabs should work
correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-01-30 21:43:37 UTC
Created attachment 145818 [details] [review]
Bug 32690: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-01-31 13:23:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-01-31 17:47:20 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass 2023-02-03 21:54:10 UTC
Doesn't apply cleanly to 22.05.x, no backport