Bug 32701 - Self checkout help page lacks required I18N JavaScript
Summary: Self checkout help page lacks required I18N JavaScript
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 28488
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-23 15:11 UTC by Owen Leonard
Modified: 2023-12-28 20:46 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14


Attachments
Bug 32701: Fix I18N JavaScript libraries on self checkout help page (2.04 KB, patch)
2023-04-23 21:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32701: Fix I18N JavaScript libraries on self checkout help page (2.08 KB, patch)
2023-04-23 23:30 UTC, David Nind
Details | Diff | Splinter Review
Bug 32701: Fix I18N JavaScript libraries on self checkout help page (2.16 KB, patch)
2023-04-25 14:43 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-23 15:11:46 UTC
If you view the self checkout help page and look in the browser console you will see an error: jQuery.Deferred exception: __ is not defined

The template does not include all the right JavaScript assets for the I18N JS to function properly.
Comment 1 Katrin Fischer 2023-04-23 21:21:05 UTC
Created attachment 150137 [details] [review]
Bug 32701: Fix I18N JavaScript libraries on self checkout help page

The help page was missing the fixes from bug 28488. The missing
libraries are causing a JavaScript error on the page and likely
other issues.

To test:
* Make sure WebBasedSelfCheck is activated and configured
  Note: In ktd you don't need to configure anything, it's already set up.
* In the OPAC, go to:
  /cgi-bin/koha/sco/sco-main.pl
* Click on the link to the help in the top right corner
* Verify you see the error in the console:
  jQuery.Deferred exception: __ is not defined
* Apply patch
* Restart things
* Reload the page
* Veriy the errors are gone
Comment 2 David Nind 2023-04-23 23:30:46 UTC
Created attachment 150145 [details] [review]
Bug 32701: Fix I18N JavaScript libraries on self checkout help page

The help page was missing the fixes from bug 28488. The missing
libraries are causing a JavaScript error on the page and likely
other issues.

To test:
* Make sure WebBasedSelfCheck is activated and configured
  Note: In ktd you don't need to configure anything, it's already set up.
* In the OPAC, go to:
  /cgi-bin/koha/sco/sco-main.pl
* Click on the link to the help in the top right corner
* Verify you see the error in the console:
  jQuery.Deferred exception: __ is not defined
* Apply patch
* Restart things
* Reload the page
* Veriy the errors are gone

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2023-04-25 14:43:21 UTC
Created attachment 150211 [details] [review]
Bug 32701: Fix I18N JavaScript libraries on self checkout help page

The help page was missing the fixes from bug 28488. The missing
libraries are causing a JavaScript error on the page and likely
other issues.

To test:
* Make sure WebBasedSelfCheck is activated and configured
  Note: In ktd you don't need to configure anything, it's already set up.
* In the OPAC, go to:
  /cgi-bin/koha/sco/sco-main.pl
* Click on the link to the help in the top right corner
* Verify you see the error in the console:
  jQuery.Deferred exception: __ is not defined
* Apply patch
* Restart things
* Reload the page
* Veriy the errors are gone

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-04-25 14:43:36 UTC
It does not make sense to have it here, but I am lazy to find a better solution (and it's already in sci-main).
Comment 5 Tomás Cohen Arazi 2023-05-05 13:15:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize 2023-05-12 14:42:42 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 7 Lucas Gass 2023-06-13 15:49:54 UTC
Backported to 22.05.x for upcoming 22.05.14
Comment 8 Danyon Sewell 2023-07-20 00:10:44 UTC
Does this need to be backported to 21.11.x?