If you view the self checkout help page and look in the browser console you will see an error: jQuery.Deferred exception: __ is not defined The template does not include all the right JavaScript assets for the I18N JS to function properly.
Created attachment 150137 [details] [review] Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone
Created attachment 150145 [details] [review] Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david@davidnind.com>
Created attachment 150211 [details] [review] Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
It does not make sense to have it here, but I am lazy to find a better solution (and it's already in sci-main).
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.14
Does this need to be backported to 21.11.x?