On bug 25655 we are going to store the cost and currency from the invoice. On this bug we will display them on the invoice summary.
Created attachment 145913 [details] [review] Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, I've decided to format them but they are not accurate to the currency. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT)
(In reply to Jonathan Druart from comment #1) > > We could discuss the display of the prices here, I've decided to format > them but they are not accurate to the currency. We cannot do better for > now as we are not storing the format along with the currency. > We would prefer unitprice and currency code (not symbol) [% order.invoice_unitprice | currency => order.invoice_currency %] Exemplar: 52.33 EUR 876.42 USD 69.38 CAD ...
Created attachment 146307 [details] [review] Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT)
Created attachment 146382 [details] [review] Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 146477 [details] [review] Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 146486 [details] [review] Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
I am happy with this one and ready to PQA, but moving to BLOCKED until we have resolved the question on the dependent bug 25655.
Created attachment 146659 [details] [review] Bug 32705: Display the column if 1 order has an invoice price On 25655 we added a new patch to store the invoice unitprice and currency even if it's the active currency. Here we then want to display the column if at least one order has an invoice price in a currency that is not the active one.
The last patch needs a signoff.
I did some tests and everything was ok ! Sign-Off via sandbox was not possible, so I change the status to 'Signed Off' manually This error message occured: No local changes to save git: 's' is not a git command. See 'git --help'. The most similar commands are show sparse-checkout status switch am bz fsck gc mv push rm No stash entries found.
(In reply to Michaela Sieber from comment #10) > I did some tests and everything was ok ! > > Sign-Off via sandbox was not possible, so I change the status to 'Signed > Off' manually > > This error message occured: > No local changes to save > git: 's' is not a git command. See 'git --help'. Reported on https://gitlab.com/koha-community/koha-sandboxes-docker/-/issues/85
Created attachment 146814 [details] [review] Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 146815 [details] [review] Bug 32705: Display the column if 1 order has an invoice price On 25655 we added a new patch to store the invoice unitprice and currency even if it's the active currency. Here we then want to display the column if at least one order has an invoice price in a currency that is not the active one. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
I have added the SO line for Michaela on the last patch in the QA step.
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement - not backporting to 22.11.x. Setting to Needs documenting. Nice work everyone!