Bug 3271 - Missing message when adding to a list with no items selected
Summary: Missing message when adding to a list with no items selected
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-29 10:04 UTC by Matthias Meusburger
Modified: 2012-10-25 23:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch for HEAD (3.99 KB, patch)
2009-05-29 10:04 UTC, Chris Cormack
Details | Diff | Splinter Review
Patch for 3.0.x (3.96 KB, patch)
2009-05-29 10:05 UTC, Chris Cormack
Details | Diff | Splinter Review
Proposed additional fix for HEAD (1.96 KB, patch)
2009-12-21 15:15 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional fix for the staff client in HEAD (1.01 KB, patch)
2010-06-28 15:16 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:08:32 UTC


---- Reported by matthias.meusburger@biblibre.com 2009-05-29 10:04:40 ----

Created an attachment
Patch for HEAD

The patch adds a message when the user tries to add to a list with no items selected, in the same way it is done for the cart.



---- Additional Comments From matthias.meusburger@biblibre.com 2009-05-29 10:05:28 ----

Created an attachment
Patch for 3.0.x





---- Additional Comments From gmcharlt@gmail.com 2009-05-29 13:57:48 ----

Patch pushed to HEAD.



---- Additional Comments From nengard@gmail.com 2009-12-17 13:50:41 ----

When in the OPAC if I choose to add to list with nothing selected - there are no warning messages.



---- Additional Comments From oleonard@myacpl.org 2009-12-21 15:15:03 ----

Created an attachment
Proposed additional fix for HEAD

This patch sets a missing js variable required in cases when the Cart is turned off.



---- Additional Comments From nengard@gmail.com 2010-02-06 23:22:06 ----

This is fixed in the OPAC, but still an issue in the staff client



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:08 UTC  ---

This bug was previously known as _bug_ 3271 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3271
Imported an attachment (id=1191)
Imported an attachment (id=1192)
Imported an attachment (id=1193)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1191 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1192 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1193 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2010-06-28 15:16:00 UTC
Created attachment 2279 [details] [review]
Additional fix for the staff client in HEAD

There is no visible Lists button to "attach" our warning to as there is in the OPAC, so warning message is displayed via a javascript alert.
Comment 2 Chris Cormack 2010-11-13 06:35:45 UTC
Patch pushed
Comment 3 Chris Nighswonger 2010-11-18 03:15:33 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 4 Chris Nighswonger 2010-11-30 13:49:38 UTC
This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1.

Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed.
Comment 5 MJ Ray (software.coop) 2010-12-10 10:23:10 UTC
This bug is mentioned in:
Fix for Bug 3271,	Missing message when adding to a list with no items selected http://lists.koha-community.org/pipermail/koha-patches/2010-November/012962.html