The upload local cover image template still uses the old sequence of breadcrumb details: Koha -> Cataloging -> Upload local cover images (see Bug 26703 - Modify the "title" elements to contain unique information first). These elements should be reversed.
Created attachment 145769 [details] [review] Bug 32738: Correct upload local cover image title tag This patch corrects the local cover image template's title tag so that it conforms to the changes made in Bug 26703, 'Modify the "title" elements to contain unique information first.' The patch also makes minor corrections to the page's breadcrumbs. To test you must have the LocalCoverImages system preference enabled. - Apply the patch and go to Cataloging -> Upload local cover image. - The page title should be correct: Upload local cover image › Cataloging › Koha - The breadcrumbs should be: Home -> Cataloging -> Upload cover image - Locate a bibliographic record and view its details. - Click the "Images" tab, then the "Upload" button. - The page title should now be Upload local cover image for [title] › Cataloging › Koha - The breadcrumbs should now be: Home -> Cataloging -> Upload local cover image -> Upload cover for [title]
Created attachment 145776 [details] [review] Bug 32738: Correct upload local cover image title tag This patch corrects the local cover image template's title tag so that it conforms to the changes made in Bug 26703, 'Modify the "title" elements to contain unique information first.' The patch also makes minor corrections to the page's breadcrumbs. To test you must have the LocalCoverImages system preference enabled. - Apply the patch and go to Cataloging -> Upload local cover image. - The page title should be correct: Upload local cover image › Cataloging › Koha - The breadcrumbs should be: Home -> Cataloging -> Upload cover image - Locate a bibliographic record and view its details. - Click the "Images" tab, then the "Upload" button. - The page title should now be Upload local cover image for [title] › Cataloging › Koha - The breadcrumbs should now be: Home -> Cataloging -> Upload local cover image -> Upload cover for [title] Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145830 [details] [review] Bug 32738: Correct upload local cover image title tag This patch corrects the local cover image template's title tag so that it conforms to the changes made in Bug 26703, 'Modify the "title" elements to contain unique information first.' The patch also makes minor corrections to the page's breadcrumbs. To test you must have the LocalCoverImages system preference enabled. - Apply the patch and go to Cataloging -> Upload local cover image. - The page title should be correct: Upload local cover image › Cataloging › Koha - The breadcrumbs should be: Home -> Cataloging -> Upload cover image - Locate a bibliographic record and view its details. - Click the "Images" tab, then the "Upload" button. - The page title should now be Upload local cover image for [title] › Cataloging › Koha - The breadcrumbs should now be: Home -> Cataloging -> Upload local cover image -> Upload cover for [title] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply clean to 22.05.x, no backport