Bug 32752 - Add new serial issue status: "Out for binding", "Bound", and "Circulating"
Summary: Add new serial issue status: "Out for binding", "Bound", and "Circulating"
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Kyle M Hall
URL:
Keywords:
: 12187 (view as bug list)
Depends on:
Blocks: 35595
  Show dependency treegraph
 
Reported: 2023-01-30 17:13 UTC by Katrin Fischer
Modified: 2024-02-01 16:16 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/829
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 32752: Use an include for displaying the serial status in the OPAC (6.80 KB, patch)
2023-03-17 10:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (10.97 KB, patch)
2023-03-17 10:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes (2.11 KB, patch)
2023-03-17 10:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.17 KB, patch)
2023-03-17 10:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include for displaying the serial status in the OPAC (6.80 KB, patch)
2023-03-17 14:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (10.97 KB, patch)
2023-03-17 14:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes (2.11 KB, patch)
2023-03-17 14:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.17 KB, patch)
2023-03-17 14:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include for displaying the serial status in the OPAC (6.80 KB, patch)
2023-03-17 14:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (10.97 KB, patch)
2023-03-17 14:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes (2.11 KB, patch)
2023-03-17 14:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.20 KB, patch)
2023-03-17 14:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include for displaying the serial status in the OPAC (6.86 KB, patch)
2023-03-17 15:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (11.03 KB, patch)
2023-03-17 15:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes (2.16 KB, patch)
2023-03-17 15:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.25 KB, patch)
2023-03-17 15:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 32752: Use an include for displaying the serial status in the OPAC (6.86 KB, patch)
2023-03-17 15:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (11.03 KB, patch)
2023-03-17 15:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Add new status Circulating, Out for binding, and Bound to includes (2.16 KB, patch)
2023-03-17 15:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.21 KB, patch)
2023-03-17 15:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include for displaying the serial status in the OPAC (6.93 KB, patch)
2023-03-17 15:26 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (11.10 KB, patch)
2023-03-17 15:26 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Add new status Circulating, Out for binding, and Bound to includes (2.23 KB, patch)
2023-03-17 15:26 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.28 KB, patch)
2023-03-17 15:26 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.25 KB, patch)
2023-03-21 18:22 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 32752: Use an include for displaying the serial status in the OPAC (6.99 KB, patch)
2023-04-21 15:00 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32752: Use an include to display the serial status in the staff interface (11.10 KB, patch)
2023-04-21 15:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32752: Add new status Circulating, Out for binding, and Bound to includes (2.29 KB, patch)
2023-04-21 15:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32752: Update serial edit form to allow for new status (3.31 KB, patch)
2023-04-21 15:01 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-30 17:13:57 UTC
Some libraries don't create items for their serial subscription issues or only create items for their bound volumes of serial issues. For these libraries, but also others, it would be really nice if the list of available serial issue status could be extend to cover some other common use cases:

* At bindery: the issue is temporarily not available because it's at the bookbinder's for treatment, usually getting bound into a volume with other issues.
* Bound: this would be when the issues have been bound and can now be checked out as a volume together with other issues of i.e. the same year
* Circulating: this would be during the time the issue is circulating through the routing list. A lot of library print the routing list and attach it to the issue, then the item is given from one person to the next person on the list, ususally within the library or institution.

Open for better suggestions regarding status names :)
Comment 1 Katrin Fischer 2023-03-17 10:11:07 UTC
Created attachment 148320 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too
Comment 2 Katrin Fischer 2023-03-17 10:11:09 UTC
Created attachment 148321 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.
Comment 3 Katrin Fischer 2023-03-17 10:11:12 UTC
Created attachment 148322 [details] [review]
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.
Comment 4 Katrin Fischer 2023-03-17 10:11:14 UTC
Created attachment 148323 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is "Arrived".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has already Arrived
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )
Comment 5 Katrin Fischer 2023-03-17 14:42:29 UTC
Created attachment 148353 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too
Comment 6 Katrin Fischer 2023-03-17 14:42:32 UTC
Created attachment 148354 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.
Comment 7 Katrin Fischer 2023-03-17 14:42:34 UTC
Created attachment 148355 [details] [review]
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.
Comment 8 Katrin Fischer 2023-03-17 14:42:36 UTC
Created attachment 148356 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has already Arrived
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )
Comment 9 Katrin Fischer 2023-03-17 14:54:33 UTC
Created attachment 148357 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too
Comment 10 Katrin Fischer 2023-03-17 14:54:35 UTC
Created attachment 148358 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.
Comment 11 Katrin Fischer 2023-03-17 14:54:37 UTC
Created attachment 148359 [details] [review]
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.
Comment 12 Katrin Fischer 2023-03-17 14:54:39 UTC
Created attachment 148360 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )
Comment 13 Biblibre Sandboxes 2023-03-17 15:08:37 UTC
Created attachment 148362 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 14 Biblibre Sandboxes 2023-03-17 15:08:40 UTC
Created attachment 148363 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 15 Biblibre Sandboxes 2023-03-17 15:08:42 UTC
Created attachment 148364 [details] [review]
Bug 32752: Add new status Circulationg, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 16 Biblibre Sandboxes 2023-03-17 15:08:44 UTC
Created attachment 148365 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 17 Katrin Fischer 2023-03-17 15:20:08 UTC
Created attachment 148366 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 18 Katrin Fischer 2023-03-17 15:20:10 UTC
Created attachment 148367 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 19 Katrin Fischer 2023-03-17 15:20:13 UTC
Created attachment 148368 [details] [review]
Bug 32752: Add new status Circulating, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 20 Katrin Fischer 2023-03-17 15:20:15 UTC
Created attachment 148369 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late issues and claim one of them
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 21 Katrin Fischer 2023-03-17 15:20:42 UTC
Fixed a mistake in the test plan and a typo in the commit message, no changes to the code.
Comment 22 Katrin Fischer 2023-03-17 15:26:04 UTC
Created attachment 148370 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 23 Katrin Fischer 2023-03-17 15:26:06 UTC
Created attachment 148371 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 24 Katrin Fischer 2023-03-17 15:26:08 UTC
Created attachment 148372 [details] [review]
Bug 32752: Add new status Circulating, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 25 Katrin Fischer 2023-03-17 15:26:10 UTC
Created attachment 148373 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late issues and claim one of them
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 26 Biblibre Sandboxes 2023-03-21 18:22:08 UTC
Created attachment 148490 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 27 Lucas Gass 2023-04-21 14:59:38 UTC
Works as described. The template changes look good. Checked all the HTML and everything is valid. QA scripts are happy. 

Nice enhancement.
Comment 28 Lucas Gass 2023-04-21 15:00:58 UTC
Created attachment 150051 [details] [review]
Bug 32752: Use an include for displaying the serial status in the OPAC

This moves the existing status in the OPAC into an include.

To test:
* Add a subscription with issues in different status
* View the OPAC detail page of the record
* Verify that in the subscription tab the status display nicely
* Veriy that More details > Full history displays the status nicely too

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 29 Lucas Gass 2023-04-21 15:01:00 UTC
Created attachment 150052 [details] [review]
Bug 32752: Use an include to display the serial status in the staff interface

This moves the identical code used to display the serial status
from the different templates into one common include.

To test:
* Add a subscription
* Receive several issues, make sure 2 are late
* Claim one of the late issues
* Verify the status displays nicely on these pages:
  * Subscription detail page > issues tab
  * Catalog detail page > subscription tab
  * Serial claims page
  * Serial collection page of your subscription

Note: there was some code for the subscription detail page
that should have displayed the claim date, but didn't work.
To keep things simpler and identical to before, I have left
that bit out for now.

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 30 Lucas Gass 2023-04-21 15:01:03 UTC
Created attachment 150053 [details] [review]
Bug 32752: Add new status Circulating, Out for binding, and Bound to includes

To test with the next patch that allows to set the new status.

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 31 Lucas Gass 2023-04-21 15:01:05 UTC
Created attachment 150054 [details] [review]
Bug 32752: Update serial edit form to allow for new status

With this patch the new status Circulating, Out for binding and
Bound can be set for any issue, if the current status is not "Expected".
This is to keep the list a little shorter when the issue hasn't even
arrived in the library yet.

These new status will be especially helpful if the library has
opted to not create items for all their subscriptions as a lot
of libraries will only lend bound volumes, but not the singular
issues.

* Circulating: this will be useful if the library is using
routing lists and the items are not available at the library
for a longer time.

* Out for binding: if you send out issues for binding this will
help to track these.

* Bound: this will help users to know that the issue is now
available as a bound volume.

To test:
* If you haven't yet:
  * Create a subscription
  * From the serial collection page:
    * Receive or create several issues and set different status
    * Make sure you have at least 2 late and claim one of them
    * Make sure you have several Arrived issues
  * Edit Arrived serial issues and others
  * Verify that the status pull down no also shows the new status
    if the issue has a different status than "Expected"
  * Set the new status
  * Verify they save and show correctly
  * Edit again and verify the pull downs are pre-set correctly
    to the saved status
  * Verify they show everywhere else (see previous test plans :) )

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 32 Katrin Fischer 2023-04-21 18:19:58 UTC
Thanks a lot!
Comment 33 Tomás Cohen Arazi 2023-05-15 21:23:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 34 Matt Blenkinsop 2023-06-02 16:17:53 UTC
Enhancement - not backporting to 22.11.x
Comment 35 Katrin Fischer 2023-07-15 19:18:01 UTC
*** Bug 12187 has been marked as a duplicate of this bug. ***