Bug 32765 - Transfer is not retried after cancelling hold
Summary: Transfer is not retried after cancelling hold
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Julian Maurice
QA Contact: Katrin Fischer
URL:
Keywords: regression
Depends on: 27064
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-31 08:46 UTC by Julian Maurice
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 32765: Retry transfer after cancelling hold (1.95 KB, patch)
2023-01-31 08:47 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32765: [21.11.x] Retry transfer after cancelling hold (1.91 KB, patch)
2023-01-31 20:46 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32765: Retry transfer after cancelling hold (2.01 KB, patch)
2023-05-08 16:07 UTC, Nicolas Giraud
Details | Diff | Splinter Review
Bug 32765: Retry transfer after cancelling hold (2.05 KB, patch)
2023-06-21 15:06 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 32765: Retry transfer after cancelling hold (2.11 KB, patch)
2023-07-29 21:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-01-31 08:46:56 UTC
When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again.

Steps to reproduce:
1. Place a hold on a specific item
2. Try to transfer it manually (Circulation » Transfer)
3. Choose the option to "Cancel hold and then attempt transfer"
4. See that the hold was cancelled, but no transfer was made
Comment 1 Julian Maurice 2023-01-31 08:47:51 UTC
Created attachment 145839 [details] [review]
Bug 32765: Retry transfer after cancelling hold

When trying to manually transfer an item that is on hold, we have the
choice to cancel the hold and try the transfer again. When choosing
this option, the hold is correctly cancelled but the transfer is not
tried again.
This patch fixes that

Test plan:
1. Place a hold on a specific item
2. Try to transfer it manually (Circulation » Transfer)
3. Choose the option to "Cancel hold and then attempt transfer"
4. See that the hold was cancelled, but no transfer was made
5. Apply the patch
6. Repeat step 1-3
7. See that the hold was cancelled, and the transfer was made
Comment 2 Julian Maurice 2023-01-31 08:52:31 UTC
Regression apparently caused by:
6ac4542948c451595a154a5467e548a43e9817e8 Bug 27064: (QA follow-up) Do not create transfer prior to accepting it
Comment 3 Fridolin Somers 2023-01-31 20:36:16 UTC
I'm on applying on 21.11.x :

Looks like Bug 31781 made some move in koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
Comment 4 Fridolin Somers 2023-01-31 20:46:15 UTC
Created attachment 145915 [details] [review]
Bug 32765: [21.11.x] Retry transfer after cancelling hold

When trying to manually transfer an item that is on hold, we have the
choice to cancel the hold and try the transfer again. When choosing
this option, the hold is correctly cancelled but the transfer is not
tried again.
This patch fixes that

Test plan:
1. Place a hold on a specific item
2. Try to transfer it manually (Circulation » Transfer)
3. Choose the option to "Cancel hold and then attempt transfer"
4. See that the hold was cancelled, but no transfer was made
5. Apply the patch
6. Repeat step 1-3
7. See that the hold was cancelled, and the transfer was made
Comment 5 Stina Hallin 2023-03-10 09:17:54 UTC
Found some code bits in the GUI, at the Transfer items page: ======= >>>>>>> Bug 32765: [21.11.x] Retry transfer after cancelling hold, and Transfer item to Fairfield: <<<<<<< HEAD, and ======= >>>>>>> Bug 32765: [21.11.x] Retry transfer after cancelling hold. Didn't manage to see that the transfer was made after clicking Cancel reservation and then attempt transfer:, maybe I didn't chose pickup location the way I should have.
Comment 6 Katrin Fischer 2023-03-11 10:37:24 UTC
These are merge markers. There is a separate patch attached here for master and 21.11, which makes this not testable in a sandbox. On master, only the first patch needs to be applied.

I wonder if there is a way we could make this work better, if we need patches for different versions.
Comment 7 Nicolas Giraud 2023-05-08 16:07:11 UTC
Created attachment 150801 [details] [review]
Bug 32765: Retry transfer after cancelling hold

When trying to manually transfer an item that is on hold, we have the
choice to cancel the hold and try the transfer again. When choosing
this option, the hold is correctly cancelled but the transfer is not
tried again.
This patch fixes that

Test plan:
1. Place a hold on a specific item
2. Try to transfer it manually (Circulation » Transfer)
3. Choose the option to "Cancel hold and then attempt transfer"
4. See that the hold was cancelled, but no transfer was made
5. Apply the patch
6. Repeat step 1-3
7. See that the hold was cancelled, and the transfer was made

Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>
Comment 8 David Nind 2023-05-09 01:37:01 UTC
Hi Nicolas.

Another one for you to change the status to Signed Off, so that you get the credit on the dashboard. 8-)

David
Comment 9 Fridolin Somers 2023-06-21 09:07:53 UTC
Comment on attachment 145915 [details] [review]
Bug 32765: [21.11.x] Retry transfer after cancelling hold

I set 21.11 patch obsolete so the one for master can be tested.

We will recreate a version for backported after pushed master.
Comment 10 Fridolin Somers 2023-06-21 09:09:20 UTC
Applies on current master
Comment 11 Sam Lau 2023-06-21 15:06:36 UTC
Created attachment 152528 [details] [review]
Bug 32765: Retry transfer after cancelling hold

When trying to manually transfer an item that is on hold, we have the
choice to cancel the hold and try the transfer again. When choosing
this option, the hold is correctly cancelled but the transfer is not
tried again.
This patch fixes that

Test plan:
1. Place a hold on a specific item
2. Try to transfer it manually (Circulation » Transfer)
3. Choose the option to "Cancel hold and then attempt transfer"
4. See that the hold was cancelled, but no transfer was made
5. Apply the patch
6. Repeat step 1-3
7. See that the hold was cancelled, and the transfer was made

Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>
Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 12 Katrin Fischer 2023-07-29 21:48:51 UTC
Created attachment 154073 [details] [review]
Bug 32765: Retry transfer after cancelling hold

When trying to manually transfer an item that is on hold, we have the
choice to cancel the hold and try the transfer again. When choosing
this option, the hold is correctly cancelled but the transfer is not
tried again.
This patch fixes that

Test plan:
1. Place a hold on a specific item
2. Try to transfer it manually (Circulation » Transfer)
3. Choose the option to "Cancel hold and then attempt transfer"
4. See that the hold was cancelled, but no transfer was made
5. Apply the patch
6. Repeat step 1-3
7. See that the hold was cancelled, and the transfer was made

Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-09-12 13:16:39 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-09-14 18:26:16 UTC
Pushed to 23.05.x for 23.05.04
Comment 15 Matt Blenkinsop 2023-09-15 10:21:41 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x