When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. Steps to reproduce: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made
Created attachment 145839 [details] [review] Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made
Regression apparently caused by: 6ac4542948c451595a154a5467e548a43e9817e8 Bug 27064: (QA follow-up) Do not create transfer prior to accepting it
I'm on applying on 21.11.x : Looks like Bug 31781 made some move in koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
Created attachment 145915 [details] [review] Bug 32765: [21.11.x] Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made
Found some code bits in the GUI, at the Transfer items page: ======= >>>>>>> Bug 32765: [21.11.x] Retry transfer after cancelling hold, and Transfer item to Fairfield: <<<<<<< HEAD, and ======= >>>>>>> Bug 32765: [21.11.x] Retry transfer after cancelling hold. Didn't manage to see that the transfer was made after clicking Cancel reservation and then attempt transfer:, maybe I didn't chose pickup location the way I should have.
These are merge markers. There is a separate patch attached here for master and 21.11, which makes this not testable in a sandbox. On master, only the first patch needs to be applied. I wonder if there is a way we could make this work better, if we need patches for different versions.
Created attachment 150801 [details] [review] Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com>
Hi Nicolas. Another one for you to change the status to Signed Off, so that you get the credit on the dashboard. 8-) David
Comment on attachment 145915 [details] [review] Bug 32765: [21.11.x] Retry transfer after cancelling hold I set 21.11 patch obsolete so the one for master can be tested. We will recreate a version for backported after pushed master.
Applies on current master
Created attachment 152528 [details] [review] Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 154073 [details] [review] Bug 32765: Retry transfer after cancelling hold When trying to manually transfer an item that is on hold, we have the choice to cancel the hold and try the transfer again. When choosing this option, the hold is correctly cancelled but the transfer is not tried again. This patch fixes that Test plan: 1. Place a hold on a specific item 2. Try to transfer it manually (Circulation » Transfer) 3. Choose the option to "Cancel hold and then attempt transfer" 4. See that the hold was cancelled, but no transfer was made 5. Apply the patch 6. Repeat step 1-3 7. See that the hold was cancelled, and the transfer was made Signed-off-by: Nicolas Giraud <nicolas.giraud@inlibro.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x