Bug 32766 - Update plugin unimarc_field_116.pl fields
Summary: Update plugin unimarc_field_116.pl fields
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Thibaud Guillot
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-31 10:43 UTC by Thibaud Guillot
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the labels for some values so that they match with the definitions in UNIMARC Bibliographic (3rd ed.) Updates, and to help with translation: - Specific material designation: i- print (no change in display) m- master -> m- mould - Techniques (drawings, paintings) 1, 2, and 3: crayon -> charcoal - Technique (prints) 1,2, and 3: Label for dropdown list changed to Techniques (print) 1, 2, and 3 camaiu -> cameo computer graphics -> infography - Functional designation ab- item cover -> ab- resource cover ag- chart -> ag- diagram
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 32766: Update some labels for better understanding and translation (9.11 KB, patch)
2023-01-31 10:46 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 32766: Update some labels for better understanding and translation (9.29 KB, patch)
2023-01-31 11:04 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 32766: Update some labels for better understanding and translation (9.41 KB, patch)
2023-01-31 11:16 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 32766: (follow-up) Fix translation function (2.37 KB, patch)
2023-01-31 14:31 UTC, Thibaud Guillot
Details | Diff | Splinter Review
Bug 32766: Update some labels for better understanding and translation (9.45 KB, patch)
2023-05-07 22:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 32766: (follow-up) Fix translation function (2.42 KB, patch)
2023-05-07 22:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 32766: Update some labels for better understanding and translation (9.51 KB, patch)
2023-05-08 21:37 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32766: (follow-up) Fix translation function (2.47 KB, patch)
2023-05-08 21:37 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32766: (QA follow-up) Remove stray p from USE statements (1.01 KB, patch)
2023-05-08 21:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot 2023-01-31 10:43:27 UTC
Update unimarc fields for plugin unimarc_field_116.pl to more precise labels for understanding and translation
Comment 1 Thibaud Guillot 2023-01-31 10:46:38 UTC Comment hidden (obsolete)
Comment 2 Thibaud Guillot 2023-01-31 11:04:44 UTC Comment hidden (obsolete)
Comment 3 Thibaud Guillot 2023-01-31 11:16:39 UTC
Created attachment 145844 [details] [review]
Bug 32766: Update some labels for better understanding and translation

examples: 'crayon'->'carchoal' or 'camaiu'->'cameo'
Comment 4 Thibaud Guillot 2023-01-31 14:31:34 UTC
Created attachment 145877 [details] [review]
Bug 32766: (follow-up) Fix translation function

The previous syntax causes a warning during the execution of the translation script
Comment 5 David Nind 2023-05-07 22:09:55 UTC
Created attachment 150794 [details] [review]
Bug 32766: Update some labels for better understanding and translation

examples: 'crayon'->'carchoal' or 'camaiu'->'cameo'
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-05-07 22:09:58 UTC
Created attachment 150795 [details] [review]
Bug 32766: (follow-up) Fix translation function

The previous syntax causes a warning during the execution of the translation script

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-05-07 22:20:10 UTC
Testing notes (using koha-testing-docker (KTD)):

1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc
2. Edit a record, view the values for tag 116, and note the before values listed in [1] that will change.
3. Apply the patch.
4. Restart everything (flush_memcached, restart_all, clear browser cache).
5. Repeat step 2 - note that the changes listed in [1] were made.

[1] Before and after changes to dropdown list values:

- Specific material designation: 
  i- print (no change in display)
  m- master -> m- mould

- Techniques (drawings, paintings) 1, 2, and 3:
  crayon -> charcoal

- Technique (prints) 1,2, and 3:
  Label for dropdown list changed to Techniques (print) 1, 2, and 3
  camaiu -> cameo
  computer graphics -> infography

- Functional designation
  ab- item cover -> ab- resource cover
  ag- chart -> ag- diagram

Other notes - full details for 116 are not available online:
- UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-updates/
Comment 8 Katrin Fischer 2023-05-08 21:37:39 UTC
Created attachment 150810 [details] [review]
Bug 32766: Update some labels for better understanding and translation

examples: 'crayon'->'carchoal' or 'camaiu'->'cameo'
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2023-05-08 21:37:41 UTC
Created attachment 150811 [details] [review]
Bug 32766: (follow-up) Fix translation function

The previous syntax causes a warning during the execution of the translation script

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2023-05-08 21:37:44 UTC
Created attachment 150812 [details] [review]
Bug 32766: (QA follow-up) Remove stray p from USE statements

+q[% SET footerjs = 1 %]
Comment 11 Katrin Fischer 2023-05-08 21:37:55 UTC
There is something wrong here:
+q[% SET footerjs = 1 %]
Comment 12 Tomás Cohen Arazi 2023-05-12 14:20:53 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 13 Matt Blenkinsop 2023-05-15 12:57:35 UTC
Nice work everyone!

Pushed to stable for 22.11.x