Bug 32768 - Autocomplete suggestions container should always be on top of other UI elements
Summary: Autocomplete suggestions container should always be on top of other UI elements
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30719
  Show dependency treegraph
 
Reported: 2023-01-31 12:34 UTC by Pedro Amorim
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements (1.44 KB, patch)
2023-01-31 12:39 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements (1.44 KB, patch)
2023-01-31 12:41 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements (1.49 KB, patch)
2023-01-31 15:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements (1.56 KB, patch)
2023-02-23 14:31 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-01-31 12:34:07 UTC
Bug 30719 introduces a modal with a patron autocomplete input in it.
Because the .modal uses a z-index: 1050 and the autocomplete container with .ui-autocomplete .ui-front CSS classes is picking up z-index: 100 from .ui-front, the autocomplete suggestions appear behind the modal dialog and can't be interacted with.

This CSS entry from addbiblio.css should be moved into global-staff.scss for wider  use:
.ui-autocomplete {
    z-index: 2000;
}
Comment 1 Pedro Amorim 2023-01-31 12:39:29 UTC Comment hidden (obsolete)
Comment 2 Pedro Amorim 2023-01-31 12:41:02 UTC
Created attachment 145849 [details] [review]
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements

This patch moves the z-index setting of .ui-autocomplete from addbiblio.css to staff-global.scss for wider use

Sponsored-by: PTFS Europe
Comment 3 Owen Leonard 2023-01-31 15:00:40 UTC
Created attachment 145882 [details] [review]
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements

This patch moves the z-index setting of .ui-autocomplete from
addbiblio.css to staff-global.scss for wider use

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Jonathan Druart 2023-02-23 14:31:38 UTC
Created attachment 147235 [details] [review]
Bug 32768: Autocomplete suggestions container should always be on top of other UI elements

This patch moves the z-index setting of .ui-autocomplete from
addbiblio.css to staff-global.scss for wider use

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-02-24 20:06:26 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-02-28 16:46:03 UTC
Nice work everyone!

Pushed to stable for 22.11.x