Bug 32771 - Standardize structure around action fieldsets in serials
Summary: Standardize structure around action fieldsets in serials
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32746
Blocks: 32744
  Show dependency treegraph
 
Reported: 2023-01-31 18:58 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32771: Standardize structure around action fieldsets in serials (3.96 KB, patch)
2023-02-01 11:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32771: Standardize structure around action fieldsets in serials (4.81 KB, patch)
2023-02-02 20:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32771: Standardize structure around action fieldsets in serials (4.85 KB, patch)
2023-02-09 19:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 32771: Standardize structure around action fieldsets in serials (4.91 KB, patch)
2023-02-24 16:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32771: Standardize structure around action fieldsets in serials (3.71 KB, patch)
2023-03-22 10:59 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-31 18:58:25 UTC
As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in serials.
Comment 1 Owen Leonard 2023-02-01 11:45:06 UTC Comment hidden (obsolete)
Comment 2 Matt Blenkinsop 2023-02-02 09:58:37 UTC
I think there is another fieldset that has been missed as the sidebar on serials-search is still inside the main form fieldset - see lines 434-440 in serials-search.tt

Does this need amending as well or is this not subject to the same standardized structure?
Comment 3 Owen Leonard 2023-02-02 20:42:10 UTC
Created attachment 146038 [details] [review]
Bug 32771: Standardize structure around action fieldsets in serials

This patch updates serials templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and rebuild the staff interface CSS. Go to
serials and check the following pages to confirm that changes to
form structure look correct:

- Navigate directly to /cgi-bin/koha/serials/serials-search.pl
  - Check the form on this page.
  - Perform a subscription search. On the search results page, check
    the sidebar form.
- Click "Manage numbering patterns" in the left-hand sidebar menu.
  - Click "New numbering pattern" and check the forms on that page.
Comment 4 David Nind 2023-02-09 19:18:12 UTC
Created attachment 146449 [details] [review]
Bug 32771: Standardize structure around action fieldsets in serials

This patch updates serials templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and rebuild the staff interface CSS. Go to
serials and check the following pages to confirm that changes to
form structure look correct:

- Navigate directly to /cgi-bin/koha/serials/serials-search.pl
  - Check the form on this page.
  - Perform a subscription search. On the search results page, check
    the sidebar form.
- Click "Manage numbering patterns" in the left-hand sidebar menu.
  - Click "New numbering pattern" and check the forms on that page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2023-02-24 16:42:39 UTC
Created attachment 147362 [details] [review]
Bug 32771: Standardize structure around action fieldsets in serials

This patch updates serials templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and rebuild the staff interface CSS. Go to
serials and check the following pages to confirm that changes to
form structure look correct:

- Navigate directly to /cgi-bin/koha/serials/serials-search.pl
  - Check the form on this page.
  - Perform a subscription search. On the search results page, check
    the sidebar form.
- Click "Manage numbering patterns" in the left-hand sidebar menu.
  - Click "New numbering pattern" and check the forms on that page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 Owen Leonard 2023-03-22 10:59:43 UTC
Created attachment 148514 [details] [review]
Bug 32771: Standardize structure around action fieldsets in serials

This patch updates serials templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and rebuild the staff interface CSS. Go to
serials and check the following pages to confirm that changes to
form structure look correct:

- Navigate directly to /cgi-bin/koha/serials/serials-search.pl
  - Check the form on this page.
  - Perform a subscription search. On the search results page, check
    the sidebar form.
- Click "Manage numbering patterns" in the left-hand sidebar menu.
  - Click "New numbering pattern" and check the forms on that page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Tomás Cohen Arazi 2023-03-31 10:38:12 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-04-11 11:33:39 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Lucas Gass 2023-04-24 17:27:39 UTC
Enhancement will not be backported to 22.05.x