Bug 20581 introduced the ability to manually select custom ILL request statuses. These custom ILL request statuses are stored in the ILLSTATUS AV and are then stored in the status_alias column of illrequests. Staff members are lead to believe that ILL statuses are stored in the ILLSTATUS authorized values list when these are just aliases used for display purposes. The actual ILL statuses are fed from the backend or Koha::Illrequest. My suggestion would be rename this to ILL_STATUS_ALIAS or ILL_STATUS_ALIASES
Created attachment 146452 [details] [review] Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias
Created attachment 146453 [details] [review] Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category
I hope I thought of everything - please test well!
Created attachment 146487 [details] [review] Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Thank you Katrin, yes. I believe your patch also addresses bug 32795.
Thanks, Pedro!
Created attachment 147171 [details] [review] Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.