Bug 32799 - ILLSTATUS authorized value category name is confusing
Summary: ILLSTATUS authorized value category name is confusing
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-02 15:07 UTC by Pedro Amorim
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/685
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS (8.82 KB, patch)
2023-02-09 21:27 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS (9.04 KB, patch)
2023-02-09 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS (9.10 KB, patch)
2023-02-10 15:45 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS (9.19 KB, patch)
2023-02-22 15:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-02-02 15:07:57 UTC
Bug 20581 introduced the ability to manually select custom ILL request statuses.
These custom ILL request statuses are stored in the ILLSTATUS AV and are then stored in the status_alias column of illrequests.

Staff members are lead to believe that ILL statuses are stored in the ILLSTATUS authorized values list when these are just aliases used for display purposes.

The actual ILL statuses are fed from the backend or Koha::Illrequest.

My suggestion would be rename this to ILL_STATUS_ALIAS or ILL_STATUS_ALIASES
Comment 1 Katrin Fischer 2023-02-09 21:27:36 UTC
Created attachment 146452 [details] [review]
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
3) Configure some authorised values for ILLSTATUS
4) Apply patch
5) Run database update
6) Verify your configured values have been updated to ILL_STATUS_ALIAS
7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the
   categories list
8) Go to the ILL module and add a new request
9) Edit the request, verify that your status alias show in the status list
10) Set one of your status and save
11) Verify that the ILL requests list search filters show your status alias
Comment 2 Katrin Fischer 2023-02-09 21:34:03 UTC
Created attachment 146453 [details] [review]
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
3) Configure some authorised values for ILLSTATUS
4) Apply patch
5) Run database update
6) Verify your configured values have been updated to ILL_STATUS_ALIAS
7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the
   categories list
8) Go to the ILL module and add a new request
9) Edit the request, verify that your status alias show in the status list
10) Set one of your status and save
11) Verify that the ILL requests list search filters show your status alias
12) Manage the request again and verify that the ILL request log shows the
    status descriptions correctly
13) Verify the description of the ILLHiddenRequestStatuses has
    been updated with the new authorised value category
Comment 3 Katrin Fischer 2023-02-09 21:34:26 UTC
I hope I thought of everything - please test well!
Comment 4 Pedro Amorim 2023-02-10 15:45:57 UTC
Created attachment 146487 [details] [review]
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
3) Configure some authorised values for ILLSTATUS
4) Apply patch
5) Run database update
6) Verify your configured values have been updated to ILL_STATUS_ALIAS
7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the
   categories list
8) Go to the ILL module and add a new request
9) Edit the request, verify that your status alias show in the status list
10) Set one of your status and save
11) Verify that the ILL requests list search filters show your status alias
12) Manage the request again and verify that the ILL request log shows the
    status descriptions correctly
13) Verify the description of the ILLHiddenRequestStatuses has
    been updated with the new authorised value category

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Pedro Amorim 2023-02-10 15:46:45 UTC
Thank you Katrin, yes. I believe your patch also addresses bug 32795.
Comment 6 Katrin Fischer 2023-02-10 15:57:10 UTC
Thanks, Pedro!
Comment 7 Jonathan Druart 2023-02-22 15:52:31 UTC
Created attachment 147171 [details] [review]
Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS

To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
3) Configure some authorised values for ILLSTATUS
4) Apply patch
5) Run database update
6) Verify your configured values have been updated to ILL_STATUS_ALIAS
7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the
   categories list
8) Go to the ILL module and add a new request
9) Edit the request, verify that your status alias show in the status list
10) Set one of your status and save
11) Verify that the ILL requests list search filters show your status alias
12) Manage the request again and verify that the ILL request log shows the
    status descriptions correctly
13) Verify the description of the ILLHiddenRequestStatuses has
    been updated with the new authorised value category

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Tomás Cohen Arazi 2023-02-27 16:07:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Jacob O'Mara 2023-03-01 16:51:28 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.