When UpdateStats records a localuse in the statistics table the location is always NULL.
Created attachment 146024 [details] [review] Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location
Created attachment 146158 [details] [review] Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
This change needs a test.
Created attachment 147249 [details] [review] Bug 32805: Add tests
(In reply to Jonathan Druart from comment #3) > This change needs a test. Added tests and setting status back to 'Signed-off'
Created attachment 147256 [details] [review] Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 147257 [details] [review] Bug 32805: Add tests JD amended patch: tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Doesn't apply to 22.05.x, no backport.