This is part of the refactoring happening in bug 30975
Created attachment 146070 [details] [review] Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146335 [details] [review] Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Julian Maurice from comment #1) > Created attachment 146070 [details] [review] [review] > Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl > > Use event parameter instead of id. > > This is part of the refactoring happening in bug 30975 Hmm. Really? It was in the EXAMPLE already in 2014. commit 331cbeb1df86ed92843ac80b74952a085be556bc Date: Fri Oct 24 11:43:34 2014 +0200 +function Click$id(event) { + var fieldvalue=\$('#'+event.data.id).val(); + window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=EXAMPLE.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); + return false; // prevents scrolling +}
(In reply to Marcel de Rooy from comment #3) > Hmm. Really? It was in the EXAMPLE already in 2014. Using the event parameter was already possible since years, but bug 30975 makes it the only way.
Created attachment 146721 [details] [review] Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
applied to 21.11.x for 21.11.19