Bug 32812 - Fix cataloguing/value_builder/barcode_manual.pl
Summary: Fix cataloguing/value_builder/barcode_manual.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 11:11 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04, 21.11.19


Attachments
Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl (986 bytes, patch)
2023-02-03 11:12 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl (1.01 KB, patch)
2023-02-07 14:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl (1.11 KB, patch)
2023-02-16 10:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 11:11:13 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:12:08 UTC
Created attachment 146070 [details] [review]
Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl

Use event parameter instead of id.

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Owen Leonard 2023-02-07 14:56:23 UTC
Created attachment 146335 [details] [review]
Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl

Use event parameter instead of id.

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2023-02-16 10:36:41 UTC
(In reply to Julian Maurice from comment #1)
> Created attachment 146070 [details] [review] [review]
> Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl
> 
> Use event parameter instead of id.
> 
> This is part of the refactoring happening in bug 30975

Hmm. Really? It was in the EXAMPLE already in 2014.

commit 331cbeb1df86ed92843ac80b74952a085be556bc
Date:   Fri Oct 24 11:43:34 2014 +0200

+function Click$id(event) {
+    var fieldvalue=\$('#'+event.data.id).val();
+    window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=EXAMPLE.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes');
+    return false; // prevents scrolling
+}
Comment 4 Julian Maurice 2023-02-16 10:40:45 UTC
(In reply to Marcel de Rooy from comment #3)
> Hmm. Really? It was in the EXAMPLE already in 2014.

Using the event parameter was already possible since years, but bug 30975 makes it the only way.
Comment 5 Marcel de Rooy 2023-02-16 10:41:12 UTC
Created attachment 146721 [details] [review]
Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl

Use event parameter instead of id.

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi 2023-02-16 15:02:06 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-02-24 07:52:53 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 8 Arthur Suzuki 2023-03-29 08:55:37 UTC
applied to 21.11.x for 21.11.19