Bug 32814 - Fix cataloguing/value_builder/callnumber-KU.pl
Summary: Fix cataloguing/value_builder/callnumber-KU.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 11:15 UTC by Julian Maurice
Modified: 2023-12-28 20:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11, 21.11.19


Attachments
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl (1.21 KB, patch)
2023-02-03 11:16 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl (1.26 KB, patch)
2023-02-07 16:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl (1.29 KB, patch)
2023-02-17 10:09 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl (1.35 KB, patch)
2023-02-17 13:54 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 11:15:53 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:16:30 UTC
Created attachment 146072 [details] [review]
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Owen Leonard 2023-02-07 16:49:08 UTC
Created attachment 146342 [details] [review]
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 David Nind 2023-02-07 17:20:13 UTC
It looks like I was testing this one at the same time as Owen!

I added this plugin to 952$o for the BKS framework (MARC21).

If I enter a value, such as AAA 0, when I click on the ... it jumps to the top of the screen (it does generate the value though - AAA 0001). It didn't do this before the patch was applied (and after a flush_memcached and restart_all).

Description of plugin
~~~~~~~~~~~~~~~~~~~~~

Is used for callnumber computation.

User must supply a letter prefix (unspecified length) followed by an empty space followed by a "number".

"Number" is 4 character long, and is either a number sequence which is 01 padded.

If input does not conform with this format any processing is omitted.

Some examples of legal values that trigger auto allocation:

AAA 0  - returns first unused number AAA 0xxx starting with AAA 0001
BBB 12 - returns first unused number BBB 12xx starting with BBB 1201
CCC QW - returns first unused number CCC QWxx starting with CCC QW01
Comment 4 Julian Maurice 2023-02-17 10:09:26 UTC
Created attachment 146755 [details] [review]
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Julian Maurice 2023-02-17 10:28:58 UTC
(In reply to David Nind from comment #3)
> If I enter a value, such as AAA 0, when I click on the ... it jumps to the
> top of the screen (it does generate the value though - AAA 0001). It didn't
> do this before the patch was applied (and after a flush_memcached and
> restart_all).

Fixed in the last patch
Comment 6 Kyle M Hall 2023-02-17 13:54:14 UTC
Created attachment 146848 [details] [review]
Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2023-02-20 12:55:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-02-24 08:31:43 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 9 Lucas Gass 2023-03-01 14:41:42 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 10 Arthur Suzuki 2023-03-29 09:15:45 UTC
applied to 21.11.x for 21.11.19
Comment 11 wainuiwitikapark 2023-04-27 04:00:19 UTC
Not backported to 21.05.x