This is part of the refactoring happening in bug 30975
Created attachment 146072 [details] [review] Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146342 [details] [review] Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org>
It looks like I was testing this one at the same time as Owen! I added this plugin to 952$o for the BKS framework (MARC21). If I enter a value, such as AAA 0, when I click on the ... it jumps to the top of the screen (it does generate the value though - AAA 0001). It didn't do this before the patch was applied (and after a flush_memcached and restart_all). Description of plugin ~~~~~~~~~~~~~~~~~~~~~ Is used for callnumber computation. User must supply a letter prefix (unspecified length) followed by an empty space followed by a "number". "Number" is 4 character long, and is either a number sequence which is 01 padded. If input does not conform with this format any processing is omitted. Some examples of legal values that trigger auto allocation: AAA 0 - returns first unused number AAA 0xxx starting with AAA 0001 BBB 12 - returns first unused number BBB 12xx starting with BBB 1201 CCC QW - returns first unused number CCC QWxx starting with CCC QW01
Created attachment 146755 [details] [review] Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to David Nind from comment #3) > If I enter a value, such as AAA 0, when I click on the ... it jumps to the > top of the screen (it does generate the value though - AAA 0001). It didn't > do this before the patch was applied (and after a flush_memcached and > restart_all). Fixed in the last patch
Created attachment 146848 [details] [review] Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11.x for 21.11.19
Not backported to 21.05.x