This is part of the refactoring happening in bug 30975
Created attachment 146073 [details] [review] Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146355 [details] [review] Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> https://bugs.koha-community.org/show_bug.cgi?id=32813
Created attachment 146356 [details] [review] Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com>
I mucked up the sign off, and have done again! Testing notes (using KTD): 1. In a MARC21 instance, add the callnumber.pl plugin to 952$o for the BKS framework. 2. Edit an item for a record and add "PREFIX 0009678570" as the call number and save. 3. Edit another item for another record. 4. For the call number, enter "PREFIX" and then click on the three dots. 5. Note that it generates the call number as "PREFIX 9678572". Note the description in the script says it should add leading zeros, but it doesn't. I have added bug 32903 for this.
Created attachment 147724 [details] [review] Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11 for 21.11.19
Not backported to 21.05.x