Bug 32818 - Clean up cataloguing/value_builder/marc21_field_005.pl
Summary: Clean up cataloguing/value_builder/marc21_field_005.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 11:26 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl (911 bytes, patch)
2023-02-03 11:27 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl (960 bytes, patch)
2023-03-28 19:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl (1017 bytes, patch)
2023-04-22 21:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 11:26:37 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:27:14 UTC
Created attachment 146076 [details] [review]
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl

Remove unnecessary return statement

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-06 15:43:53 UTC
This one is actually only a cleanup patch that is not needed for bug 30975.
Removing the dependency link
Comment 3 David Nind 2023-03-28 19:51:36 UTC
Created attachment 148847 [details] [review]
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl

Remove unnecessary return statement

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-28 19:59:45 UTC
How I tested
~~~~~~~~~~~~

1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs.
2. Apply this patch - say no to apply dependent bugs (already done is step 1).
3. The plugin marc21_field_005.pl is already added to 005 for the MARC21 bibliographic frameworks in KTD.
4. Edit a bibliographic record: empty the 005 field, change to another field, then click back into 005 - it should be autopopulated with a value.
5. Create a new record and click in 005 -  - it should be autopopulated with a value.

Description
~~~~~~~~~~~

This is a standard cataloguing plugin. It autopopulates the 005 field with the required value when you click in the field. (From the Library of Congress: Sixteen characters that indicate the date and time of the latest record transaction and serve as a version identifier for the record.)
Comment 5 Katrin Fischer 2023-04-22 21:18:40 UTC
Created attachment 150095 [details] [review]
Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl

Remove unnecessary return statement

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-24 13:49:14 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-05-10 12:53:54 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.