Bug 32821 - Fix cataloguing/value_builder/stocknumber.pl
Summary: Fix cataloguing/value_builder/stocknumber.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency tree / graph
 
Reported: 2023-02-03 11:45 UTC by Julian Maurice
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11, 21.11.19
Circulation function:

Attachments
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl (1.21 KB, patch)
2023-02-03 11:45 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl (1.26 KB, patch)
2023-02-07 16:56 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl (1.29 KB, patch)
2023-02-17 10:09 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl (1.34 KB, patch)
2023-02-17 15:09 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 11:45:08 UTC 
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:45:54 UTC 
Created attachment 146079 [details] [review]
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Owen Leonard 2023-02-07 16:56:36 UTC 
Created attachment 146344 [details] [review]
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Julian Maurice 2023-02-17 10:09:59 UTC 
Created attachment 146758 [details] [review]
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Kyle M Hall (khall) 2023-02-17 15:09:29 UTC 
Created attachment 146851 [details] [review]
Bug 32821: Fix cataloguing/value_builder/stocknumber.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-20 12:55:08 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-02-24 08:31:50 UTC 
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 7 Lucas Gass (lukeg) 2023-03-01 14:43:28 UTC 
Backported to 22.05.x for upcoming 22.05.11
Comment 8 Arthur Suzuki 2023-03-29 09:16:11 UTC 
applied to 21.11.x for 21.11.19
Comment 9 Wainui Witika-Park 2023-04-27 04:25:39 UTC 
Not backported to 21.05.x