Bug 32822 - Fix cataloguing/value_builder/unimarc_field_010.pl
Summary: Fix cataloguing/value_builder/unimarc_field_010.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 11:47 UTC by Julian Maurice
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19
Circulation function:


Attachments
Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl (1.26 KB, patch)
2023-02-03 11:47 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl (1.31 KB, patch)
2023-02-18 22:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl (1.36 KB, patch)
2023-02-24 16:27 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 11:47:06 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:47:38 UTC
Created attachment 146080 [details] [review]
Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 David Nind 2023-02-18 22:26:13 UTC
Created attachment 146930 [details] [review]
Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-02-18 22:29:46 UTC
How I tested
~~~~~~~~~~~~

1. Add the unimarc_field_010.pl plugin to 010$a for the default UNIMARC framework.
2. Edit an existing record, or create a new record.
3. Enter 9782070612369 in 010$a.
4. Check 210$c - automatically populated with Gallimard.

Description
~~~~~~~~~~~

This plugin tries to find the publisher from the ISBN entered in 010$a and add it to 210$c.
Comment 4 Nick Clemens (kidclamp) 2023-02-24 16:27:53 UTC
Created attachment 147357 [details] [review]
Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-24 19:56:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-02-28 16:40:38 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-03-08 13:32:05 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 8 Arthur Suzuki 2023-03-29 12:33:13 UTC
applied to 21.11 for 21.11.19
Comment 9 Wainui Witika-Park 2023-04-27 05:27:47 UTC
Not backported to 21.05.x