Bug 32824 - Fix cataloguing/value_builder/unimarc_field_100.pl
Summary: Fix cataloguing/value_builder/unimarc_field_100.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 12:41 UTC by Julian Maurice
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19


Attachments
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl (1.13 KB, patch)
2023-02-03 12:42 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl (1.17 KB, patch)
2023-02-17 10:10 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl (1.22 KB, patch)
2023-02-19 18:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl (1.28 KB, patch)
2023-02-24 16:46 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 12:41:32 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 12:42:16 UTC
Created attachment 146083 [details] [review]
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:10:21 UTC
Created attachment 146760 [details] [review]
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-02-19 18:39:06 UTC
Created attachment 146934 [details] [review]
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-02-19 20:35:20 UTC
How I tested
~~~~~~~~~~~~

1. The unimarc_field_100.pl plugin is already added to 100$a for the default UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for 100$a.
4. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select and enter the values that make up the 100$a subfield.
Comment 5 Nick Clemens 2023-02-24 16:46:01 UTC
Created attachment 147364 [details] [review]
Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-02-24 19:56:46 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-01 09:45:02 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-03-10 14:17:54 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-29 12:58:37 UTC
applied to 21.11 for 21.11.19
Comment 10 wainuiwitikapark 2023-04-27 05:35:35 UTC
Not backported to 21.05.x