Bug 32825 - Fix cataloguing/value_builder/unimarc_field_105.pl
Summary: Fix cataloguing/value_builder/unimarc_field_105.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 12:43 UTC by Julian Maurice
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19
Circulation function:


Attachments
Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl (1.55 KB, patch)
2023-02-03 12:43 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl (1.59 KB, patch)
2023-02-17 10:10 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32835: Fix cataloguing/value_builder/unimarc_field_122.pl (1.62 KB, patch)
2023-02-19 20:30 UTC, David Nind
Details | Diff | Splinter Review
Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl (1.64 KB, patch)
2023-02-24 16:42 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 12:43:24 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 12:43:55 UTC
Created attachment 146090 [details] [review]
Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:10:32 UTC
Created attachment 146761 [details] [review]
Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-02-19 20:30:10 UTC
Created attachment 146935 [details] [review]
Bug 32835: Fix cataloguing/value_builder/unimarc_field_122.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-02-19 20:33:34 UTC
How I tested
~~~~~~~~~~~~

1. The unimarc_field_105.pl plugin is already added to 105$a for the default UNIMARC bibliographic framework in KTD.
2. Edit a record.
3. Select the tag editor for 105$a.
4. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~
This is a standard UNIMARC value builder for a subfield - it displays a form to select and enter the values that make up the 105$a subfield.
Comment 5 Nick Clemens (kidclamp) 2023-02-24 16:42:05 UTC
Created attachment 147361 [details] [review]
Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-02-24 19:56:50 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-02-28 16:46:10 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-03-08 13:44:52 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-29 12:35:12 UTC
applied to 21.11 for 21.11.19
Comment 10 Wainui Witika-Park 2023-04-27 05:30:09 UTC
Not backported to 21.05.x