This is part of the refactoring happening in bug 30975
Created attachment 146096 [details] [review] Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146767 [details] [review] Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 148619 [details] [review] Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com>
How I tested ~~~~~~~~~~~~ 1. The plugin is already added to the subfield for the default UNIMARC bibliographic framework in KTD. 2. Edit a bibliographic record. 3. Select the tag editor for the subfield. 4. Options and values should be the same before and after the patch is applied. Description ~~~~~~~~~~~ This is a standard UNIMARC value builder for a subfield - it displays a form to select and enter the values that make up the subfield.
Created attachment 148634 [details] [review] Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x